Fix database event.data.val() bug #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base payload had a length property
rjhuijsman
reviewed
May 2, 2017
spec/providers/database.spec.ts
Outdated
| expect(subject.val()).to.deep.equal({ myOtherKey: 'bar' }); | ||
| }); | ||
|
|
||
| // Regression test: .val() was returning array of nulls when there's a property called length |
Contributor
There was a problem hiding this comment.
Can you add "BUG(37683995)" in this comment, for our future reference if we want to remember more details?
src/providers/database.ts
Outdated
| } else { | ||
| allIntegerKeys = false; | ||
| for (let key in node) { | ||
| if (node.hasOwnProperty(key)) { |
Contributor
There was a problem hiding this comment.
You can remove a level of indentation for the code below, by using:
if (!node.hasOwnProperty(key)) { continue; }
Contributor
Author
|
@rjhuijsman done! Thanks for the tip! |
rjhuijsman
approved these changes
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug where event.data.val() was returning array of nulls when database payload had a length property.
Code sample
If new database node looks like:
{ length: "something", foo: "bar"}
Previously, calling event.data.val() would return array of nulls (since lodash's _.forEach method thought that the data was actually an array due to the presence of the length property, and tried to iterate over teh nonexistent array elements). Now, event.data.val() will return the expected value of { length: "something", foo: "bar"}