Fix lint errors for auth, analytics, crashlytics, remoteconfig tests #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinajian
reviewed
Jun 13, 2019
spec/providers/analytics.spec.ts
Outdated
| const cloudFunction = analytics | ||
| .event('first_open') | ||
| .onLog((data: analytics.AnalyticsEvent) => data); | ||
| .onLog((event: analytics.AnalyticsEvent) => event); |
Contributor
There was a problem hiding this comment.
should the other ones also be changed to event?
Contributor
Author
There was a problem hiding this comment.
Good point. I was renaming this specific instance because of a shadowed variable down lower that is also called data. Event providers should all take in (data, context), here it looks we're just cutting some corners by not passing two arguments, which I think makes things more confusing. Since this is this is the first argument I'm actually reconsidering naming this data and changing the other var to something else.
kevinajian
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of lint fixes now in
spec/providersdirectory.