Add shim to fix GCS media links with slashes, remove shim that removed spurious GCS events #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a shim to side-step an issue awaiting a server-side fix: when receiving a GCS event for a nested object (name has "slashes/in/it"), the "mediaLink" field contains a URL that has literal slashes ("/") when it should contain URL-escaped slashes ("%2F"). The code added in this PR fixes that.
This PR also removes a previous shim that is no longer needed: GCS no longer generates spurious events on function deployment, hence the code we added to skip those invocations can be removed.