From 8ddb7a9dec248caf48b703ca9db5c41665c75002 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natan=20S=C4=85gol?= Date: Tue, 9 Jul 2019 21:29:26 +0200 Subject: [PATCH 1/3] Run Prettier for all supported file formats --- .prettierignore | 3 +++ package.json | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 .prettierignore diff --git a/.prettierignore b/.prettierignore new file mode 100644 index 000000000..de457f940 --- /dev/null +++ b/.prettierignore @@ -0,0 +1,3 @@ +lib +package.json +spec/fixtures/credential/unparsable.key.json diff --git a/package.json b/package.json index 969f64585..7ff35c350 100644 --- a/package.json +++ b/package.json @@ -24,8 +24,8 @@ "build:pack": "rm -rf lib && npm install && tsc -p tsconfig.release.json && npm pack", "build:release": "npm install --production && npm install typescript firebase-admin && tsc -p tsconfig.release.json", "build": "tsc -p tsconfig.release.json", - "format": "prettier --check '**/*.ts'", - "format:fix": "prettier --write '**/*.ts'", + "format": "prettier --check '**/*.{json,md,ts,yml,yaml}'", + "format:fix": "prettier --write '**/*.{json,md,ts,yml,yaml}'", "lint": "tslint --config tslint.json --project tsconfig.json ", "lint:fix": "tslint --config tslint.json --fix --project tsconfig.json", "test": "mocha -r ts-node/register ./spec/index.spec.ts" From 84e1097fe97b64b295e958bd596ae5f30586fd25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Natan=20S=C4=85gol?= Date: Tue, 9 Jul 2019 21:30:14 +0200 Subject: [PATCH 2/3] Reformat all files --- .github/CONTRIBUTING.md | 2 +- .github/ISSUE_TEMPLATE/---feature-request.md | 6 ++++-- .github/ISSUE_TEMPLATE/---report-a-bug.md | 11 +++++------ .github/PULL_REQUEST_TEMPLATE.md | 7 +++---- integration_test/README.md | 6 +++--- integration_test/functions/tsconfig.json | 8 ++------ 6 files changed, 18 insertions(+), 22 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 6ec97c9ef..b918352d7 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -21,4 +21,4 @@ All submissions, including submissions by project members, require review. We use GitHub pull requests for this purpose. Consult [GitHub Help] for more information on using pull requests. -[GitHub Help]: https://help.github.com/articles/about-pull-requests/ \ No newline at end of file +[github help]: https://help.github.com/articles/about-pull-requests/ diff --git a/.github/ISSUE_TEMPLATE/---feature-request.md b/.github/ISSUE_TEMPLATE/---feature-request.md index d47fbda18..93f7d6de1 100644 --- a/.github/ISSUE_TEMPLATE/---feature-request.md +++ b/.github/ISSUE_TEMPLATE/---feature-request.md @@ -1,12 +1,14 @@ --- name: "\U0001F4A1 Feature Request" -about: Have a feature you'd like to see in the functions SDK? Request it through our +about: + Have a feature you'd like to see in the functions SDK? Request it through our support channel. title: '' labels: '' assignees: '' --- - diff --git a/.github/ISSUE_TEMPLATE/---report-a-bug.md b/.github/ISSUE_TEMPLATE/---report-a-bug.md index 4484df5fa..694c4aedf 100644 --- a/.github/ISSUE_TEMPLATE/---report-a-bug.md +++ b/.github/ISSUE_TEMPLATE/---report-a-bug.md @@ -1,12 +1,12 @@ --- -name: "⚠️ Report a Bug" +name: '⚠️ Report a Bug' about: Think you found a bug in the SDK? Report it here. title: '' labels: '' assignees: '' - --- - @@ -21,11 +21,13 @@ template_path=.github/ISSUE_TEMPLATE/---report-a-bug.md be fixed in the latest versions. --> **node:** + **firebase-functions:** **firebase-tools:** + **firebase-admin:** @@ -34,17 +36,14 @@ be fixed in the latest versions. --> - ### [REQUIRED] Steps to reproduce - ### [REQUIRED] Expected behavior - ### [REQUIRED] Actual behavior - ### Description \ No newline at end of file + diff --git a/integration_test/README.md b/integration_test/README.md index d0a1f3ef9..c6a0ca32d 100644 --- a/integration_test/README.md +++ b/integration_test/README.md @@ -1,13 +1,13 @@ -How to Use ---------- +## How to Use -***ATTENTION***: Running this test will wipe the contents of the Firebase project(s) you run it against. Make sure you use disposable Firebase project(s)! +**_ATTENTION_**: Running this test will wipe the contents of the Firebase project(s) you run it against. Make sure you use disposable Firebase project(s)! Run the integration test as follows: ```bash ./run_tests.sh [] ``` + If just one project_id is provided, the both the node6 and node8 tests will be run on that project, in series. If two project_ids are provided, the node6 tests will be run on the first project and the node8 tests will be run on the second one, in parallel. The tests run fully automatically, and will print the result on standard out. The integration test for HTTPS is that it properly kicks off other integration tests and returns a result. From there the other integration test suites will write their results back to the database, where you can check the detailed results if you'd like. diff --git a/integration_test/functions/tsconfig.json b/integration_test/functions/tsconfig.json index a8e9362db..a5bd57033 100644 --- a/integration_test/functions/tsconfig.json +++ b/integration_test/functions/tsconfig.json @@ -6,11 +6,7 @@ "noImplicitAny": false, "outDir": "lib", "declaration": true, - "typeRoots": [ - "node_modules/@types" - ] + "typeRoots": ["node_modules/@types"] }, - "files": [ - "src/index.ts" - ] + "files": ["src/index.ts"] } From 1a59f11ed50ed6ad5a264ef2dde841465aadd9a7 Mon Sep 17 00:00:00 2001 From: Diana Tkachenko Date: Tue, 9 Jul 2019 23:21:57 -0700 Subject: [PATCH 3/3] formatter fixes --- tsconfig.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tsconfig.json b/tsconfig.json index 0992f6d5b..2f7cc7e0d 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,7 +1,7 @@ { "compilerOptions": { "resolveJsonModule": true, - "sourceMap": true, + "sourceMap": true }, "extends": "./tsconfig.release.json", "include": ["./src/**/*.ts", "./spec/**/*.ts"]