Use process.env.FIREBASE_PROJECT for Firebase config values if available #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Must use with this branch of the CLI to see functions and config emulation in action: firebase/firebase-tools#328 |
inlined
requested changes
May 9, 2017
src/config.ts
Outdated
| } catch (e) { | ||
| try { | ||
| loaded = require('../../../config.json'); | ||
| loadedFromFile = require('../../../config.json'); |
Member
There was a problem hiding this comment.
This caused confusion with @samtstern's functions and was meant to be alpha behavior. Should we cut this or give a deprecation notice?
| it('throws an error if Firebase configs not present', () => { | ||
| mockRequire('../../../.runtimeconfig.json', {}); | ||
| expect(config).to.throw('Firebase config variables are missing.'); | ||
| expect(config).to.throw('Firebase config variables are not available.'); |
Member
There was a problem hiding this comment.
We added more complex behaviors. Could we test them? Hint: I'm pretty sure I see a bug =p
inlined
approved these changes
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use FIREBASE_PROJECT and CLOUD_RUNTIME_CONFIG during population of function.config(), in anticipating of these env variables being available in the runtime in the future.
Code sample