Skip to content

Conversation

@esmacik
Copy link
Contributor

@esmacik esmacik commented Jul 18, 2019

  • Adding code comments to database.ts for database.ref() method, database.RefBuilder and database.DataSnapshot from existing database-externs.js file
  • Adding @hidden tags to any variable or method with an underscore before it in database.DataSnapshot

@esmacik esmacik requested a review from egilmorez July 18, 2019 19:52
@esmacik
Copy link
Contributor Author

esmacik commented Jul 18, 2019

Here's also a link to see the staged changes 😄 https://firebase.devsite.corp.google.com/docs/reference/functions/providers_database_.html

@thechenky thechenky self-assigned this Jul 18, 2019
Copy link
Contributor

@thechenky thechenky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@esmacik esmacik merged commit cc66323 into master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants