From 76ae3d9fc73462c47d7d8d4cc29df16b5b4a9fcd Mon Sep 17 00:00:00 2001 From: Rich Hodgkins Date: Wed, 22 Apr 2020 13:58:20 +0100 Subject: [PATCH] Allow no return value for action from DataSnapshot.forEach This is to match the Admin SDK: https://github.com/firebase/firebase-js-sdk/blob/37b98e9271c494a0fb58ca1960f8fcfaec49ade9/packages/database/src/api/DataSnapshot.ts#L137 --- src/providers/database.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/providers/database.ts b/src/providers/database.ts index e648be20e..78614a152 100644 --- a/src/providers/database.ts +++ b/src/providers/database.ts @@ -476,7 +476,7 @@ export class DataSnapshot { * @return `true` if enumeration was canceled due to your callback * returning `true`. */ - forEach(action: (a: DataSnapshot) => boolean): boolean { + forEach(action: (a: DataSnapshot) => boolean | void): boolean { const val = this.val(); if (_.isPlainObject(val)) { return _.some(