Skip to content

fix: onRequest type definitions #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020
Merged

fix: onRequest type definitions #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5b141
fix: onRequest type definitions
sk- May 31, 2020
83ec498
Merge branch 'master' into fix_onRequest_types
laurenzlong Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cloud-functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export interface Runnable<T> {
* arguments.
*/
export type HttpsFunction = TriggerAnnotated &
((req: Request, resp: Response) => void);
((req: Request, resp: Response) => void | Promise<void>);

/**
* The Cloud Function type for all non-HTTPS triggers. This should be exported
Expand Down
4 changes: 2 additions & 2 deletions src/providers/https.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export interface Request extends express.Request {
* same signature as an Express app.
*/
export function onRequest(
handler: (req: Request, resp: express.Response) => void
handler: (req: Request, resp: express.Response) => void | Promise<void>
): HttpsFunction {
return _onRequestWithOptions(handler, {});
}
Expand All @@ -56,7 +56,7 @@ export function onCall(

/** @hidden */
export function _onRequestWithOptions(
handler: (req: Request, resp: express.Response) => void,
handler: (req: Request, resp: express.Response) => void | Promise<void>,
options: DeploymentOptions
): HttpsFunction {
// lets us add __trigger without altering handler:
Expand Down