Skip to content

Fix onRequest handler return type to allow promises (async) #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Fix onRequest handler return type to allow promises (async) #705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c15e4fa
Fix onRequest handler return type to allow promises (async)
p-young Jun 11, 2020
a6d3352
Merge branch 'master' into fix-function-builder-onRequest-types
mbleigh Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/function-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,10 @@ export class FunctionBuilder {
* same signature as an Express app.
*/
onRequest: (
handler: (req: https.Request, resp: express.Response) => void
handler: (
req: https.Request,
resp: express.Response
) => void | Promise<void>
) => https._onRequestWithOptions(handler, this.options),
/**
* Declares a callable method for clients to call using a Firebase SDK.
Expand Down