Update tests to change region based on env variable FIREBASE_FUNCTIONS_TEST_REGION #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FUNCTIONS_TEST_REGION
joehan
commented
Sep 14, 2020
| export const createUserTests: any = functions.auth.user().onCreate((u, c) => { | ||
| const testId: string = u.displayName; | ||
| console.log(`testId is ${testId}`); | ||
| const REGION = process.env.FIREBASE_FUNCTIONS_TEST_REGION || 'us-central1'; |
Contributor
Author
There was a problem hiding this comment.
This (and the .region(REGION) calls) are the only real changes in this file - the formatter just happened to move everything around slightly.
mbleigh
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates integration tests to use the region specified in the environment variable FIREBASE_FUNCTIONS_TEST_REGION. If not set, defaults to 'us-central1'.
Code sample
export FIREBASE_FUNCTIONS_TEST_REGION=europe-west1
./integration-test/run_tests.sh