introduce package-lock.json
#781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
Sep 15, 2020
Contributor
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
This looks good to me - I searched thru a bunch of old github issues and chat threads, and I couldn't find any reason why we shouldn't have a package-lock.json in this repo
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are a bunch of
npm auditissues that cannot be dealt with without apackage-lock.jsonfile. Additionally,istanbulis required but it is (a) unused, as far as I see, and (b) deprecated, so I've removed it.Any reason why
package-lock.jsonshouldn't be included in this repository?