From 2b6d2175d2e04c401e61b49c6a7956ab2143b736 Mon Sep 17 00:00:00 2001 From: Marcel Goya Date: Thu, 12 Nov 2020 20:18:34 +0100 Subject: [PATCH 1/3] Add IngressSettings support --- src/function-configuration.ts | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/function-configuration.ts b/src/function-configuration.ts index 558895148..9ce560087 100644 --- a/src/function-configuration.ts +++ b/src/function-configuration.ts @@ -45,7 +45,7 @@ export const VALID_MEMORY_OPTIONS = [ ] as const; /** - * List of available options for VpcConnectorEgressSettings. + * List of available options for IngressSettings. */ export const VPC_EGRESS_SETTINGS_OPTIONS = [ 'VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED', @@ -53,6 +53,16 @@ export const VPC_EGRESS_SETTINGS_OPTIONS = [ 'ALL_TRAFFIC', ] as const; +/** + * List of available options for + */ +export const INGRESS_SETTINGS_OPTIONS = [ + "INGRESS_SETTINGS_UNSPECIFIED", + "ALLOW_ALL", + "ALLOW_INTERNAL_ONLY", + "ALLOW_INTERNAL_AND_GCLB" +] as const; + /** * Scheduler retry options. Applies only to scheduled functions. */ @@ -110,6 +120,11 @@ export interface RuntimeOptions { * Egress settings for VPC connector */ vpcConnectorEgressSettings?: typeof VPC_EGRESS_SETTINGS_OPTIONS[number]; + + /** + * Ingress settings + */ + ingressSettings?:typeof INGRESS_SETTINGS_OPTIONS[number]; } export interface DeploymentOptions extends RuntimeOptions { From f7dd7d046fec110fa174f74408b0825a7dca0f09 Mon Sep 17 00:00:00 2001 From: Marcel Goya Date: Thu, 12 Nov 2020 20:22:18 +0100 Subject: [PATCH 2/3] Add IngressSettings support --- src/function-configuration.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/function-configuration.ts b/src/function-configuration.ts index 9ce560087..99a0ca268 100644 --- a/src/function-configuration.ts +++ b/src/function-configuration.ts @@ -45,7 +45,7 @@ export const VALID_MEMORY_OPTIONS = [ ] as const; /** - * List of available options for IngressSettings. + * List of available options for VpcConnectorEgressSettings. */ export const VPC_EGRESS_SETTINGS_OPTIONS = [ 'VPC_CONNECTOR_EGRESS_SETTINGS_UNSPECIFIED', @@ -54,7 +54,7 @@ export const VPC_EGRESS_SETTINGS_OPTIONS = [ ] as const; /** - * List of available options for + * List of available options for IngressSettings. */ export const INGRESS_SETTINGS_OPTIONS = [ "INGRESS_SETTINGS_UNSPECIFIED", From 7798cccccf969062e06a9cc4fc39a237a25b58a9 Mon Sep 17 00:00:00 2001 From: joehan Date: Tue, 24 Nov 2020 13:01:16 -0800 Subject: [PATCH 3/3] Format --- src/function-configuration.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/function-configuration.ts b/src/function-configuration.ts index 645774979..10098a745 100644 --- a/src/function-configuration.ts +++ b/src/function-configuration.ts @@ -58,10 +58,10 @@ export const VPC_EGRESS_SETTINGS_OPTIONS = [ * List of available options for IngressSettings. */ export const INGRESS_SETTINGS_OPTIONS = [ - "INGRESS_SETTINGS_UNSPECIFIED", - "ALLOW_ALL", - "ALLOW_INTERNAL_ONLY", - "ALLOW_INTERNAL_AND_GCLB" + 'INGRESS_SETTINGS_UNSPECIFIED', + 'ALLOW_ALL', + 'ALLOW_INTERNAL_ONLY', + 'ALLOW_INTERNAL_AND_GCLB', ] as const; /** @@ -125,7 +125,7 @@ export interface RuntimeOptions { /** * Ingress settings */ - ingressSettings?:typeof INGRESS_SETTINGS_OPTIONS[number]; + ingressSettings?: typeof INGRESS_SETTINGS_OPTIONS[number]; } export interface DeploymentOptions extends RuntimeOptions {