Skip to content

Add ingress settings support #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Add ingress settings support #815

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b6d217
Add IngressSettings support
Nov 12, 2020
f7dd7d0
Add IngressSettings support
Nov 12, 2020
cdd8463
Merge branch 'master' into master
joehan Nov 24, 2020
7798ccc
Format
joehan Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/function-configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,16 @@ export const VPC_EGRESS_SETTINGS_OPTIONS = [
'ALL_TRAFFIC',
] as const;

/**
* List of available options for IngressSettings.
*/
export const INGRESS_SETTINGS_OPTIONS = [
'INGRESS_SETTINGS_UNSPECIFIED',
'ALLOW_ALL',
'ALLOW_INTERNAL_ONLY',
'ALLOW_INTERNAL_AND_GCLB',
] as const;

/**
* Scheduler retry options. Applies only to scheduled functions.
*/
Expand Down Expand Up @@ -111,6 +121,11 @@ export interface RuntimeOptions {
* Egress settings for VPC connector
*/
vpcConnectorEgressSettings?: typeof VPC_EGRESS_SETTINGS_OPTIONS[number];

/**
* Ingress settings
*/
ingressSettings?: typeof INGRESS_SETTINGS_OPTIONS[number];
}

export interface DeploymentOptions extends RuntimeOptions {
Expand Down