Skip to content

Fixing issue reading env.DATABASE_URL and process.env.STORAGE_BUCKET_URL #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 19, 2021
Merged

Fixing issue reading env.DATABASE_URL and process.env.STORAGE_BUCKET_URL #840

merged 4 commits into from
Jan 19, 2021

Conversation

@RezaRahmati
Copy link
Contributor

@RezaRahmati RezaRahmati commented Jan 4, 2021

Description

Fixing #829

Code sample

@samtstern
Copy link
Contributor

samtstern commented Jan 5, 2021

@RezaRahmati thank you for this PR! I can confirm the behavior you described:

> const x = undefined;
undefined
> `${x}`
'undefined'
> `${process.env.NONSENSE}`
'undefined'
> process.env.NONSENSE || 'foo'
'foo'

Assigning to @joehan to approve and merge.

@samtstern samtstern requested a review from joehan January 5, 2021 10:35
@joehan joehan merged commit 8869169 into firebase:master Jan 19, 2021
@samtstern samtstern mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joehan joehan joehan approved these changes

+1 more reviewer

@samtstern samtstern samtstern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RezaRahmati @samtstern @joehan @googlebot