Set Access Control for HTTP Functions (v1) #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
changed the title
joehan
approved these changes
Jul 29, 2021
Contributor
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
Some minor feedback, but this mostly LGTM
inlined
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating a way for customers to explicitly set the access control on HTTP triggered functions. The access control is set at the function level, so different functions can have different access policies. The customer can choose to set access control to
public,private, or a custom service account. Access control is set in therunWith()function by setting the propertyinvoker. To handle multiple service accounts,invokercan accept an array of strings.The corresponding firebase-tools PR is here
Code sample
export const myHttpFunc = runWith({invoker: "private"}).onRequest((req, res) => { res.send({hello: "private"}); });