Print a useful error explaining why Runtime Config doesn't work #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbleigh
approved these changes
Aug 3, 2021
src/v1/config.ts
Outdated
| // K_CONFIGURATION is only set in GCFv2 | ||
| if (process.env.K_CONFIGURATION) { | ||
| throw new Error( | ||
| 'RuntimeConfig is no longer available in Google Cloud Functions v2. ' + |
Contributor
There was a problem hiding this comment.
Suggested change
| 'RuntimeConfig is no longer available in Google Cloud Functions v2. ' + | |
| 'functions.config() is no longer available in Cloud Functions for Firebase v2. ' + |
we never actually called it "Runtime Config" other than the filename, and only Firebase has it at all
taeold
approved these changes
Aug 3, 2021
spec/v1/config.spec.ts
Outdated
| delete process.env.K_CONFIGURATION; | ||
| }); | ||
|
|
||
| it('Will never load in GCFv2', () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it('Will never load in GCFv2', () => { | |
| it('will never load in GCFv2', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the box