Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay patch mutation bug #10579

Merged
merged 4 commits into from Jan 3, 2023
Merged

Fix overlay patch mutation bug #10579

merged 4 commits into from Jan 3, 2023

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Dec 15, 2022

No description provided.

@google-oss-bot
Copy link

google-oss-bot commented Dec 15, 2022

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.24% (391d9f2) to 88.23% (ad74432) by -0.02%.

    FilenameBase (391d9f2)Merge (ad74432)Diff
    local_documents_view.cc96.82%96.85%+0.03%
    ordered_code.cc94.39%93.90%-0.49%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kPCd1aNDtU.html

Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits below

Firestore/core/src/model/overlayed_document.h Outdated Show resolved Hide resolved
Firestore/core/test/unit/testutil/testutil.cc Outdated Show resolved Hide resolved
@ehsannas ehsannas merged commit 96e30e6 into master Jan 3, 2023
@ehsannas ehsannas deleted the wuandy/OverlayPatchFix branch January 3, 2023 18:24
@firebase firebase locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants