Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebaseApp.configure() memory leak #1636

Closed
AndriyGo opened this issue Aug 5, 2018 · 2 comments
Closed

FirebaseApp.configure() memory leak #1636

AndriyGo opened this issue Aug 5, 2018 · 2 comments
Assignees
Milestone

Comments

@AndriyGo
Copy link

@AndriyGo AndriyGo commented Aug 5, 2018

[READ] Step 1: Are you in the right place?

Yes

[REQUIRED] Step 2: Describe your environment

  • Xcode version: 9.4.1
  • Firebase SDK version: 5.5.0
  • Firebase Component: Core
  • Component version: 5.1.0

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

I have added FirebaseApp.configure() to didFinishLaunchingWithOptions. Now if I push another view controller I get the following leak:

screen shot 2018-08-05 at 16 17 36

If I do not move from the first view controller which is presented, the leak does not occur.

Relevant Code:

You can check the sample project which I created on GitHub. For security reasons, I omitted GoogleService-Info.plist, so you'll need to add it prior to running the project.

For some reason, instruments call tree is not populated for this trial project in the same way as for my original project, but the leak is still there and it is the same leak. Also, I've had some runs when the leak would not occur. From my experience, to reproduce it you need:

  1. Attach to target and wait for the first leaks check which should be successful
  2. Now click on "Trigger leak button". The second check should fail.
@baolocdo
Copy link

@baolocdo baolocdo commented Aug 6, 2018

I could reproduce this. Tracked internally at b/112265892. I have a fix for it and will have the fix in the next release

@morganchen12 morganchen12 added this to the M31 milestone Aug 6, 2018
@baolocdo
Copy link

@baolocdo baolocdo commented Aug 15, 2018

The fix should be released in Analytics 5.1.1. Please update and let us know whether you still see the leak. Thanks for reporting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants