Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Links shouldn't read from defaultOptions #2112

Closed
ryanwilson opened this issue Nov 22, 2018 · 5 comments
Closed

Dynamic Links shouldn't read from defaultOptions #2112

ryanwilson opened this issue Nov 22, 2018 · 5 comments
Assignees
Milestone

Comments

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Nov 22, 2018

Currently Dynamic Links reads from the defaultOptions plist to get the API key - this should be fetched from FIRApp incase developers manually set options.

This was discovered by @forsen in #230.

@doddyth
Copy link

@doddyth doddyth commented Nov 27, 2018

Any update for this issue? Right now, we're stuck. Any help will be appreciated. Thank you.

@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Nov 27, 2018

I'll try to take a look today to see how invasive the change will be - hopefully it's easy to pipe through.

@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Nov 27, 2018

This was fixed and will be out in the next release.

@doddyth
Copy link

@doddyth doddyth commented Nov 30, 2018

Wow, thank you for the fast fixed! May I know when 5.14 release come out?

@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Nov 30, 2018

You're very welcome 😄 by policy, we don't commit to dates for upcoming releases, but I will say that we are hoping to get 5.14.0 out with this issue fixed next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants