Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on GoogleUtilities Swizzler #2591

Closed
paulb777 opened this issue Mar 19, 2019 · 7 comments
Closed

Standardize on GoogleUtilities Swizzler #2591

paulb777 opened this issue Mar 19, 2019 · 7 comments

Comments

@paulb777
Copy link
Member

@paulb777 paulb777 commented Mar 19, 2019

Standardize swizzler usage with the GoogleUtilities Swizzler in FirebaseAuth and FirebaseMessaging.

@paulb777 paulb777 changed the title Standardize Swizzler usage with GULSwizzler Standardize on GoogleUtilities Swizzler Mar 19, 2019
@paulb777
Copy link
Member Author

@paulb777 paulb777 commented Mar 20, 2019

Contact @tejasd when ready to start working on a PR for this.

@maksymmalyhin maksymmalyhin self-assigned this Mar 25, 2019
@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Mar 25, 2019

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Apr 5, 2019

Remaining work:

  • Messaging: update swizzling of UNUserNotificationCenter ?
  • GULAppDelegateSwizzler - add macOS support (#2706)
  • Use private header in tests instead of this

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Apr 8, 2019

Is this something that has to go in with Firebase 6 or is just a nice to have?

@paulb777
Copy link
Member Author

@paulb777 paulb777 commented Apr 8, 2019

It either needs to be with Firebase 6 or reverted. We shouldn't have the release branch not match a major release.

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Apr 8, 2019

All 3 points are nice to have and are basically, nice improvements. I think, we should release the changes once #2743 is ready and create a separate ticket for those nice-to-have things.

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Apr 8, 2019

I created a separate ticket for the improvements: #2766.

@firebase firebase locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants