Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isContentToUploadValid throws NSException when data is nil #2852

Closed
LinusU opened this issue Apr 17, 2019 · 0 comments · Fixed by #2902

Comments

@LinusU
Copy link

commented Apr 17, 2019

[REQUIRED] Step 2: Describe your environment

  • Xcode version: 10.2 (10E125)
  • Firebase SDK version: 5.4.1
  • Firebase Component: Storage
  • Component version: 3.1.1

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

Creating an FIRStorageUploadTask with a nil data parameter causes an unhandled NSException in another thread when trying to run the task, effectively killing the app.

Relevant Code:

The problem is discussed at the PR which introduced the lines that failes here: #2458 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.