Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Sign in with Apple Support #3145

Closed
ajkolean opened this issue Jun 5, 2019 · 95 comments
Closed

FR: Sign in with Apple Support #3145

ajkolean opened this issue Jun 5, 2019 · 95 comments

Comments

@ajkolean
Copy link

@ajkolean ajkolean commented Jun 5, 2019

Add support for authenticating with Sign in with Apple. Soon Apple will require that you implement this to be listed on the App Store if your App uses other 3rd party login providers.

https://developer.apple.com/sign-in-with-apple/
https://developer.apple.com/documentation/signinwithapplerestapi

@StevenEWright
Copy link

@StevenEWright StevenEWright commented Jun 5, 2019

At least one of the places Apple is explicit about requiring Apple Sign In in the future: https://developer.apple.com/news/?id=06032019j

Sign In with Apple will be available for beta testing this summer. It will be required as an option for users in apps that support third-party sign-in when it is commercially available later this year.

It's not clear if / how they will distinguish between AuthN and AuthZ use cases.

@Francescu
Copy link

@Francescu Francescu commented Jun 7, 2019

Also, here is the WWDC video link:
https://developer.apple.com/videos/play/wwdc2019/706/

@Reedyuk
Copy link

@Reedyuk Reedyuk commented Jun 11, 2019

It would also appear that Apple will eventually reject app store submissions with apps that contains SSO but not apples one.
Which is a little worrying.

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Jun 11, 2019

@Reedyuk Thanks for the input. Is it officially documented?

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Jun 11, 2019

@morganchen12 I mean the source of "Apple will eventually reject app store submissions with apps that contains SSO but not apples one."

@andygeers
Copy link

@andygeers andygeers commented Jun 11, 2019

It does say it in that blog post that StevenEWright shared at the very top of this thread

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Jun 11, 2019

I think I misunderstood what @Reedyuk means by "SSO" above.
If it's "use sign in with Apple across apps", then we're well informed of it.
If it's "enterprise single sign-on" introduced in iOS 13, I didn't see Apple has additional app store review guidelines over it.

@Reedyuk
Copy link

@Reedyuk Reedyuk commented Jun 11, 2019

No, sorry for the confusion, i meant normal sso and not enterprise.
I think its a really harsh from Apple to make this mandatory and i think they even mention the apple sign on is to appear above all of the other sso buttons.

@AlexLike
Copy link

@AlexLike AlexLike commented Jun 26, 2019

+1 Even though you can technically implement Apple Sign In with Firebase already (using Custom Auth), I'd really appreciate a native option with an integration in the Firebase Console.

@jacobg
Copy link

@jacobg jacobg commented Jun 30, 2019

Here is the corresponding issue in the firebase-js-sdk in order to support hybrid apps (e.g., Cordova):

firebase/firebase-js-sdk#1931

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Jul 10, 2019

Thanks for the feature request. The Firebase Auth team is working on this.

@sylvioleblanc
Copy link

@sylvioleblanc sylvioleblanc commented Jul 19, 2019

Thanks @renkelvin ... Where’s the best place to listen for updates on the progress of the Firebase implementation of Sign-In with Apple?

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Jul 19, 2019

On this issue. There's not much progress-wise that we can report in a meaningful way without implicitly creating unreliable timeline expectations, so there haven't been many updates here. However, we are committed to releasing Sign in with Apple support before Sign in with Apple is mandatory for new apps, which is expected to happen in fall of this year.

@Brian-Co
Copy link

@Brian-Co Brian-Co commented Jul 26, 2019

Support for iOS 13 release would be much appreciated 🙏

@SloanHawthorne
Copy link

@SloanHawthorne SloanHawthorne commented Aug 10, 2019

Any update on this?

@giladrom
Copy link

@giladrom giladrom commented Aug 10, 2019

Same. This is going to be mandatory very soon. Any updates?

@mechmatt01
Copy link

@mechmatt01 mechmatt01 commented Aug 10, 2019

Well, I doubt Apple will make you have it on launch. I may be wrong and although they are stern on their rules look at their support for the iPhone X mandate. It took almost a year for them to even support iMovie for the X. I am not hating on Apple, but I am saying that they usually don’t follow their deadlines, nor do they make others follow them until further down the road. But I could be wrong on this one.

@lidemin
Copy link

@lidemin lidemin commented Aug 10, 2019

Hmm, the catch is if you want to please Apple which potentially features your app, you'd better do whatever they say...

@KrisConrad
Copy link

@KrisConrad KrisConrad commented Aug 10, 2019

It’s also nice to support features that users want at launch. As a user, I’ve replaced apps that have taken too long to support functionality I thought was important.

As a developer I don’t want to put my users in that position.

@mechmatt01
Copy link

@mechmatt01 mechmatt01 commented Aug 11, 2019

Ok, points taken.

@sylvioleblanc
Copy link

@sylvioleblanc sylvioleblanc commented Aug 12, 2019

@devcexx
Copy link

@devcexx devcexx commented Oct 22, 2019

Given the amount of work involved in adding a new custom IDP protocol, we are targeting release of native Apple Sign-In functionality on iOS in Q4 2019 barring any major technical hurdles.

Hi everyone, I just want to make sure is this still in track for Q4 2019? Or should we use this https://medium.com/@piazzachris/how-to-authenticate-a-user-with-sign-in-with-apple-and-firebase-using-a-custom-token-80dedbc24dd?

I won't use that post "as-is" to implement Apple Sign In, since it seems that the author has forgotten to write the part where he actually verifies the authentication against Apple ID servers, from the server-side

@juanscolari
Copy link

@juanscolari juanscolari commented Nov 7, 2019

Is there an estimated date when this feature will be released?

@LeXa777
Copy link

@LeXa777 LeXa777 commented Nov 7, 2019

Is there an estimated date when this feature will be released?

I doubt we will get any meaningful response, other then, 'we're working on it - should be out soon, blah blah'. I'm about to submit my app for review without the Apple Sign In button in a week or so and I'm a bit worried, but fingers crossed Apple is still flexible on this as otherwise I'm screwed.

@aplourde
Copy link

@aplourde aplourde commented Nov 7, 2019

Is there an estimated date when this feature will be released?

I doubt we will get any meaningful response, other then, 'we're working on it - should be out soon, blah blah'. I'm about to submit my app for review without the Apple Sign In button in a week or so and I'm a bit worried, but fingers crossed Apple is still flexible on this as otherwise I'm screwed.

We've submitted 3 versions since the release of iOS 13 without Apple Sign In (we do offer Google, Facebook and usr/pwd authentication). Apple never complained about it yet !

@giladrom
Copy link

@giladrom giladrom commented Nov 7, 2019

@cpboyd
Copy link

@cpboyd cpboyd commented Nov 7, 2019

I doubt we will get any meaningful response, other then, 'we're working on it - should be out soon, blah blah'. I'm about to submit my app for review without the Apple Sign In button in a week or so and I'm a bit worried, but fingers crossed Apple is still flexible on this as otherwise I'm screwed.

We've submitted 3 versions since the release of iOS 13 without Apple Sign In (we do offer Google, Facebook and usr/pwd authentication). Apple never complained about it yet !

FYI existing apps have a slightly longer period to add Apple Sign-in.

The exact wording makes it sound like NEW apps must have Apple Sign-in (if they offer any third-party sign-in services) if they want to be approved.

As I'm sure we're all well-aware, new apps typically go through a more stringent approval process than updates.

@LeXa777
Copy link

@LeXa777 LeXa777 commented Nov 7, 2019

Great, thanks for confirming that folks, I guess I can be more relaxed now 🤠

@ksilz
Copy link

@ksilz ksilz commented Nov 8, 2019

FYI existing apps have a slightly longer period to add Apple Sign-in.

The exact wording makes it sound like NEW apps must have Apple Sign-in (if they offer any third-party sign-in services) if they want to be approved.

The Apple guidelines seem pretty clear:

  • New apps must have Apple Sign-in now if they offer any third-party sign-in services (true since September).
  • Existing apps (probably as in "in App Store already before September 12") with third-party sign-in service must have Apple Sign-in by April 2020 at the latest.
@giladrom
Copy link

@giladrom giladrom commented Nov 8, 2019

@landorid
Copy link

@landorid landorid commented Nov 9, 2019

We just published an application with email/pwd and Facebook login without any problem. The guidle is clear: Apps that exclusively use a third-party or social login service ... So if you have email login, U Will have no problem.

@andreimateiro
Copy link

@andreimateiro andreimateiro commented Nov 9, 2019

We just published an application with email/pwd and Facebook login without any problem. The guidle is clear: Apps that exclusively use a third-party or social login service ... So if you have email login, U Will have no problem.

That's not actually true. I published a new app with only: social login + anonymous browse (no email/pw option)

@LeXa777
Copy link

@LeXa777 LeXa777 commented Nov 10, 2019

Don't want to get into the guidelines debate here, just wanted to note however that Apple can be a bit lenient in the first few months or so when a new feature has been introduced (how lenient and for how long is anyone's guess). So although I find it really useful to hear other people experiences at this moment (as I'm about to submit my own app too in the next few days) I wouldn't make any long term conclusions based on this info alone.

@paulb777 paulb777 added this to the M60 milestone Nov 13, 2019
@IchordeDionysos
Copy link

@IchordeDionysos IchordeDionysos commented Nov 14, 2019

By the way found this comment on the Firebase UI ticket:

firebase/FirebaseUI-iOS#698 (comment)

Upstream Firebase has all the necessary SDK changes in place. We're finishing up console support for Sign in with Apple.

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Nov 14, 2019

This is available in the latest SDK release (6.13.0). See the Sign in with Apple guide for details on implementing it. If you encounter any bugs with the new Sign in with Apple behavior, please file them in a new issue.

Thanks all for your patience!

@knikolou
Copy link

@knikolou knikolou commented Nov 21, 2019

Dear Unfortunately Apple start reject APPS because of Apple Sign In
Guideline 4.8 - Design - Sign in with Apple
We noticed that your app uses a third-party login service but does not offer Sign in with Apple.
Next Steps
To resolve this issue, please revise your app to offer Sign in with Apple as an equivalent login option.
Resources

@LouisCAD
Copy link

@LouisCAD LouisCAD commented Nov 21, 2019

@knikolou Apple Sign In is available in Firebase in open beta, so you can use it straightaway.

@melsam
Copy link

@melsam melsam commented Nov 21, 2019

When will Apple Sign In be added to FirebaseUI?

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Nov 21, 2019

@melsam Sign in with Apple is available in FirebaseUI 8.4.0.

@ssbaval
Copy link

@ssbaval ssbaval commented Nov 27, 2019

I can see Apple sign in (Beta) in Firestore console which is great. However, I cannot see any Flutter plugin that allows apple sign in ? Firebase Auth 0.15.0+1 doesnt have apple sign in as a provider - So how can we make use of this now ?

@paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 27, 2019

@ssbaval Please check in the Flutter community.

@IAmKio
Copy link

@IAmKio IAmKio commented Dec 1, 2019

Thanks for everyone's help with this - it's a great effort. I just wanted to add i've also started receiving app rejections because i do not offer Apple Sign In. Will be upgrading asap!

@rumnat
Copy link

@rumnat rumnat commented Dec 2, 2019

Is it for new or existing apps?

@melsam
Copy link

@melsam melsam commented Dec 5, 2019

@melsam Sign in with Apple is available in FirebaseUI 8.4.0.

Where is the documentation for using Apple Sign In with FirebaseUI? None of the current FirebaseUI documentation mentions Apple. I tried adding pod 'FirebaseUI/Apple' to my podfile and that didn't work either.

@kplatfoot
Copy link

@kplatfoot kplatfoot commented Dec 6, 2019

@melsam Add the pod FirebaseUI/OAuth and then include FUIOAuth.appleAuthProvider() in your auth provider list (only on iOS 13+, of course). Hope this helps!

@melsam
Copy link

@melsam melsam commented Dec 6, 2019

@melsam Add the pod FirebaseUI/OAuth and then include FUIOAuth.appleAuthProvider() in your auth provider list (only on iOS 13+, of course). Hope this helps!

Thanks @kplatfoot that was it!

@firebase firebase locked and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet