Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upNon-ASCII character in app name causes crash in +[NSBundle bundleWithIdentifier:] #3951
Comments
This comment was marked as resolved.
This comment was marked as resolved.
I found a few problems with this issue:
|
This comment has been minimized.
This comment has been minimized.
@burkaslarry can you share the full stack trace of the crash? You can print the stack trace in the debugger by running |
This comment has been minimized.
This comment has been minimized.
Also, there's some logging we have in this area that may help narrow down possible causes. Could you enable debug logging and post the output? |
This comment has been minimized.
This comment has been minimized.
Hey @burkaslarry. We need more information to resolve this issue but there hasn't been an update in 7 days. I'm marking the issue as stale and if there are no new updates in the next 3 days I will close it automatically. If you have more information that will help us get to the bottom of this, just add a comment! |
This comment has been minimized.
This comment has been minimized.
Since there haven't been any recent updates here, I am going to close this issue. @burkaslarry if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this. |
This comment has been minimized.
This comment has been minimized.
I have same problem when my app name is chinese, once I change app name to english then it work fine, how can i fix it? It work fine when I use Firestore 5.9.0, but crash when I upgrade to 6.11.0. |
This comment has been minimized.
This comment has been minimized.
@flyingbacon can you share the full stack trace of the crash and debug logs mentioned above? |
This comment has been minimized.
This comment has been minimized.
do you mean this? |
This comment has been minimized.
This comment has been minimized.
Thanks, it looks like this is the relevant stack trace:
@flyingbacon can you also share the debug logs mentioned in this comment: #3951 (comment) |
This comment has been minimized.
This comment has been minimized.
@morganchen12 i only got this log after i enable debug logging |
This comment has been minimized.
This comment has been minimized.
@flyingbacon Based on the callstack it looks like the crash is actually happening in iOS CoreFoundation code, not in Firestore, which would be pretty strange. As a sanity-check, can you just call Also, just to confirm, the problem only happens if you have Chinese characters in the app name? Can you provide an example of a problematic name and how you are setting it (i.e. Packaging > Product Name under the Target settings in XCode? Or something else?). I can try to reproduce and see what happens. Thanks! |
This comment has been minimized.
This comment has been minimized.
I call [NSBundle bundleWithIdentifier:@"org.cocoapods.grpcpp"]; like the image show, and it work fine. About the app name with chinese characters, this is how I setting it and the problem just happen with project using latest version firebase, my old project with version 5.9.0 just fine. maybe you can give me some suggestion to downgrade? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
OK. If you keep having issues or are able to come up with a way for us to reproduce it, please let us know. |
This comment has been minimized.
This comment has been minimized.
Seeing the exact same issue with app name containing the letter "Ø". |
This comment has been minimized.
This comment has been minimized.
@rolfb Thanks! Can you provide exact instructions in order to reproduce? Or an existing project that we can just open / run? |
This comment has been minimized.
This comment has been minimized.
@mikelehen Fastest way to reproduce is to change the target product name of an existing app to something like |
This comment has been minimized.
This comment has been minimized.
@rolfb Thank you! The tip about looking for It looks like this is most likely an Apple bug. I can reproduce the same crash by just calling |
This comment has been minimized.
This comment has been minimized.
Potentially related to rdar://26897226, since it's failing in bundle path validation. |
This comment has been minimized.
This comment has been minimized.
I created a minimal-ish repro here and (I think?) logged a bug against Apple using their "Feedback assistant" here: https://feedbackassistant.apple.com/feedback/7454511 though I'm not sure if that's public or not. For now, we have a possible workaround for Firestore that @var-const is working on implementing. |
This comment has been minimized.
This comment has been minimized.
@mikelehen that’s really great. The link wasn’t available even if I logged in with my Apple Developer ID. Appreciate the thoroughness. |
This comment has been minimized.
This comment has been minimized.
Manually setting CFBundleDisplayName in Info.plist –– viewed as source, not Plist –– to |
This comment has been minimized.
This comment has been minimized.
FYI, we shipped our workaround for this issue as a part of FirebaseFirestore 1.8.1. |
I use firebase firestore to develop . In this morning , no crash
as night, it gives exception at [NSBundle bundleWithIdentifier:@“org.cocoapods.grpcpp”] as screenshot stated . I have no clue on my pod settings or code... Would you please tell me what to fix?
Below is my screen shot :
Below is my code :
Personally, I have tested that even using Dispatch async to update the progress but it fails .
Below is my Installed dependencies :