Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64e slice to Firebase Analytics #4110

Closed
doganov opened this issue Oct 17, 2019 · 5 comments
Closed

Add arm64e slice to Firebase Analytics #4110

doganov opened this issue Oct 17, 2019 · 5 comments

Comments

@doganov
Copy link

@doganov doganov commented Oct 17, 2019

A full year has passed since arm64e was announced. The arm64e support in Xcode 11 is still considered experimental, but Apple advises us to test our apps in advance in order to prepare in for the moment when arm64e becomes a required architecture. App authors still can't do that today if their app depends on Firebase Analytics.

This also applies to all binary-only dependencies that Firebase Analytics itself depends on.

[READ] Step 1: Are you in the right place?

  • For issues or feature requests related to the code in this repository
    file a Github issue.
    • If this is a feature request make sure the issue title starts with "FR:".
  • For general technical questions, post a question on StackOverflow
    with the firebase tag.
  • For general Firebase discussion, use the firebase-talk
    google group.
  • For help troubleshooting your application that does not fall under one
    of the above categories, reach out to the personalized
    Firebase support channel.

[REQUIRED] Step 2: Describe your environment

  • Xcode version: 11.1
  • Firebase SDK version: 6.10.0 installed via Cocoapods
  • Firebase Component: Analytics (Auth, Core, Database, Firestore, Messaging, Storage, etc)
  • Component version: 6.10.0 (Core), 6.1.3 (Analytics)

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

When arm64e is enabled as an architecture, Xcode 11.1 fails to link the target app because there is missing arm64e slice in Firebase Analytics (and perhaps some of its dependencies):

Undefined symbols for architecture arm64e:
  "_OBJC_CLASS_$_FIRAnalytics", referenced from:
      objc-class-ref in IosAnalytics.o
     (maybe you meant: _OBJC_CLASS_$_FIRAnalyticsConfiguration)
ld: symbol(s) not found for architecture arm64e
@google-oss-bot

This comment was marked as resolved.

Copy link

@google-oss-bot google-oss-bot commented Oct 17, 2019

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@paulb777

This comment has been minimized.

Copy link
Member

@paulb777 paulb777 commented Oct 17, 2019

@doganov Thanks for the request! We'll investigate and follow-up here

@paulb777

This comment has been minimized.

Copy link
Member

@paulb777 paulb777 commented Nov 18, 2019

Implementation is done. See #4342.

The release will go out the next time Analytics releases with Firebase - which is still TBD.

@paulb777

This comment has been minimized.

Copy link
Member

@paulb777 paulb777 commented Dec 6, 2019

Now planned for the next release.

@paulb777 paulb777 added this to the M61 milestone Dec 6, 2019
@paulb777

This comment has been minimized.

Copy link
Member

@paulb777 paulb777 commented Dec 17, 2019

Fix released with Firebase 6.14.0

@paulb777 paulb777 closed this Dec 17, 2019
@firebase firebase locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.