We are in the process of creating a shared framework that contains Firebase. When the framework is imported on the new app, the application crashes right away while trying to retrieve pending deeplinks.
Steps to reproduce:
Create a shared framework with firebase in it.
Import it in a new project and configure firestore on th app delegate.
The main application will crash.
There aren't any custom domains on the Info.plist.
Relevant Code:
Snippet from FIRDLJavaScriptExecutor.m
#pragma mark - WKNavigationDelegate
- (void)webView:(WKWebView *)webView
didFinishNavigation:(null_unspecified WKNavigation *)navigation {
__weak __typeof__(self) weakSelf = self;
// Make sure that the javascript was loaded successfully before calling the method.
[webView evaluateJavaScript:FIRDLTypeofFingerprintJSMethodNameString()
completionHandler:^(id _Nullable typeofResult, NSError *_Nullable typeError) {
if (typeError) {
[weakSelf handleExecutionError:typeError];
return;
}
if ([typeofResult isEqual:@"function"]) {
[webView
evaluateJavaScript:GINFingerprintJSMethodString()
completionHandler:^(id _Nullable result, NSError *_Nullable functionError) {
if ([result isKindOfClass:[NSStringclass]]) {
[weakSelf handleExecutionResult:result];
// ^^^^^^^^ CRASH due to weakSelf being deallocated.
} else {
[weakSelf handleExecutionError:nil];
}
}];
} else {
[weakSelf handleExecutionError:nil];
}
}];
}
I'm getting the same crash using DynamicLinks in an iOS App rather than a shared framework. Adding the key FirebaseDeepLinkAutomaticRetrievalEnabled with a value of NO to the Info.plist does seem to fix the issue. I've also noticed that I don't have this issue with the zipped version of 6.13.0, only with the Carthage version.
Environment
Problem
We are in the process of creating a shared framework that contains Firebase. When the framework is imported on the new app, the application crashes right away while trying to retrieve pending deeplinks.
Steps to reproduce:
configure
firestore on th app delegate.There aren't any custom domains on the Info.plist.
Relevant Code:
Snippet from
FIRDLJavaScriptExecutor.m
Stacktrace
NOTES
We've been able to workaround the issue by adding
FirebaseDeepLinkAutomaticRetrievalEnabled
toInfo.plist
Related: #3945
Thanks !
The text was updated successfully, but these errors were encountered: