diff --git a/.github/workflows/firestore.yml b/.github/workflows/firestore.yml index 548153496f4..613b1a292d4 100644 --- a/.github/workflows/firestore.yml +++ b/.github/workflows/firestore.yml @@ -514,9 +514,8 @@ jobs: spm-binary: uses: ./.github/workflows/common.yml with: - target: FirebaseFirestore + target: FirebaseFirestoreTests platforms: iOS - buildonly_platforms: iOS check-firestore-internal-public-headers: needs: check diff --git a/Firestore/Swift/Tests/Unit/AsyncAwait/AsyncSequenceTests.swift b/Firestore/Swift/Tests/Unit/AsyncAwait/AsyncSequenceTests.swift index 4fdb05fae73..37f454a4c56 100644 --- a/Firestore/Swift/Tests/Unit/AsyncAwait/AsyncSequenceTests.swift +++ b/Firestore/Swift/Tests/Unit/AsyncAwait/AsyncSequenceTests.swift @@ -123,7 +123,7 @@ private struct Swizzler: ~Copyable { swizzledSelector: Selector) { guard let originalMethod = class_getInstanceMethod(cls, originalSelector), let swizzledMethod = class_getInstanceMethod(cls, swizzledSelector) else { - #expect(false, "Failed to get methods for swizzling") + #expect(Bool(false), "Failed to get methods for swizzling") return } method_exchangeImplementations(originalMethod, swizzledMethod) @@ -230,7 +230,7 @@ struct QueryAsyncSequenceTests { let task = Task { for try await _ in query.snapshots { - #expect(false, "The stream should not have produced any values.") + #expect(Bool(false), "The stream should not have produced any values.") } } @@ -350,7 +350,7 @@ struct DocumentReferenceAsyncSequenceTests { let task = Task { for try await _ in docRef.snapshots { - #expect(false, "The stream should not have produced any values.") + #expect(Bool(false), "The stream should not have produced any values.") } } @@ -398,4 +398,4 @@ extension DocumentReference { } } -extension String: Error {} +extension String: @retroactive Error {} diff --git a/Package.swift b/Package.swift index 5288224f44b..c8eb1117d02 100644 --- a/Package.swift +++ b/Package.swift @@ -1377,6 +1377,18 @@ let package = Package( .headerSearchPath("../../.."), ] ), + .testTarget( + name: "FirebaseFirestoreTests", + dependencies: [ + "Firebase", + "FirebaseCore", + "FirebaseFirestoreTarget", + ], + path: "Firestore/Swift/Tests/Unit", + cSettings: [ + .headerSearchPath("../../../"), + ] + ), ] + firestoreTargets(), cxxLanguageStandard: CXXLanguageStandard.gnucxx14 ) @@ -1552,18 +1564,6 @@ func firestoreTargets() -> [Target] { .swiftLanguageMode(SwiftLanguageMode.v5), ] ), - .testTarget( - name: "FirebaseFirestoreTests", - dependencies: [ - "Firebase", - "FirebaseCore", - "FirebaseFirestoreTarget", - ], - path: "Firestore/Swift/Tests/Unit", - cSettings: [ - .headerSearchPath("../../../"), - ] - ), ] } diff --git a/scripts/spm_test_schemes/FirebaseFirestoreTests.xcscheme b/scripts/spm_test_schemes/FirebaseFirestoreTests.xcscheme new file mode 100644 index 00000000000..4dcedcdd29d --- /dev/null +++ b/scripts/spm_test_schemes/FirebaseFirestoreTests.xcscheme @@ -0,0 +1,54 @@ + + + + + + + + + + + + + + + + + + + + +