Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make missing analytics a warning instead of error #1653

Merged
merged 4 commits into from Aug 9, 2018

Conversation

@paulb777 paulb777 requested review from ryanwilson and baolocdo Aug 8, 2018

@googlebot googlebot added the cla: yes label Aug 8, 2018

@ryanwilson
Copy link
Member

left a comment

LGTM but please wait for Alex to submit.

@baolocdo
Copy link
Collaborator

left a comment

I think this is a bit "unhelpful". The QA got this message and he had no idea what he did wrong until I pointed out that he forgot to link Analytics framework. Can we make it more actionable like "Please link FirebaseAnalytics framework"? Thanks

paulb777 added 2 commits Aug 8, 2018
@paulb777

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2018

@baolocdo Does this work?

@"it, include Firebase/Core in the Podfile or add "
@"FirebaseAnalytics.framework to the Link Build Phase");
FIRLogWarning(kFIRLoggerCore, @"I-COR000022",
@"Firebase Analytics is not available. To add "

This comment has been minimized.

Copy link
@baolocdo

baolocdo Aug 9, 2018

Collaborator

nit: please fill all the width of the columns (should be 100 char/column).

@paulb777 paulb777 merged commit 6c30f47 into master Aug 9, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paulb777 paulb777 deleted the pb-anal-warning branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.