-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make missing analytics a warning instead of error #1653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please wait for Alex to submit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit "unhelpful". The QA got this message and he had no idea what he did wrong until I pointed out that he forgot to link Analytics framework. Can we make it more actionable like "Please link FirebaseAnalytics framework"? Thanks
@baolocdo Does this work? |
Firebase/Core/FIRApp.m
Outdated
@"it, include Firebase/Core in the Podfile or add " | ||
@"FirebaseAnalytics.framework to the Link Build Phase"); | ||
FIRLogWarning(kFIRLoggerCore, @"I-COR000022", | ||
@"Firebase Analytics is not available. To add " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: please fill all the width of the columns (should be 100 char/column).
To reduce confusion on questions like https://stackoverflow.com/questions/51627290/5-4-1-firebase-corei-cor000022-firebase-analytics-is-not-available/51737237