Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make missing analytics a warning instead of error #1653

Merged
merged 4 commits into from Aug 9, 2018
Merged

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Aug 8, 2018

To reduce confusion on questions like https://stackoverflow.com/questions/51627290/5-4-1-firebase-corei-cor000022-firebase-analytics-is-not-available/51737237

@paulb777 paulb777 requested review from ryanwilson and baolocdo Aug 8, 2018
Copy link
Member

@ryanwilson ryanwilson left a comment

LGTM but please wait for Alex to submit.

Loading

Copy link

@baolocdo baolocdo left a comment

I think this is a bit "unhelpful". The QA got this message and he had no idea what he did wrong until I pointed out that he forgot to link Analytics framework. Can we make it more actionable like "Please link FirebaseAnalytics framework"? Thanks

Loading

@paulb777
Copy link
Member Author

@paulb777 paulb777 commented Aug 9, 2018

@baolocdo Does this work?

Loading

@"it, include Firebase/Core in the Podfile or add "
@"FirebaseAnalytics.framework to the Link Build Phase");
FIRLogWarning(kFIRLoggerCore, @"I-COR000022",
@"Firebase Analytics is not available. To add "
Copy link

@baolocdo baolocdo Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please fill all the width of the columns (should be 100 char/column).

Loading

@paulb777 paulb777 merged commit 6c30f47 into master Aug 9, 2018
2 checks passed
Loading
@paulb777 paulb777 deleted the pb-anal-warning branch Aug 9, 2018
@firebase firebase locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants