Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Messaging FIRApp Class Category #1666

Merged
merged 2 commits into from Aug 14, 2018
Merged

Remove Messaging FIRApp Class Category #1666

merged 2 commits into from Aug 14, 2018

Conversation

@bstpierr
Copy link
Contributor

@bstpierr bstpierr commented Aug 9, 2018

Merge the config setup to FIRMessaging rather than a FIRApp class category.

Merge the config setup to FIRMessaging rather than a FIRApp class category.
@bstpierr bstpierr requested a review from ryanwilson Aug 9, 2018
@@ -65,6 +65,10 @@
/* End PBXAggregateTarget section */

/* Begin PBXBuildFile section */
Copy link
Member

@paulb777 paulb777 Aug 9, 2018

Run pod deintegrate

Copy link
Contributor Author

@bstpierr bstpierr Aug 9, 2018

Ahh, thanks! I was wondering if this was expected or not.

Copy link
Member

@ryanwilson ryanwilson left a comment

That's a nice cleanup! Thanks. LGTM but please wait for @chliangGoogle's approval.

@@ -6631,12 +6631,12 @@
BUNDLE_LOADER = "$(TEST_HOST)";
CLANG_ANALYZER_NONNULL = YES;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
Copy link
Member

@ryanwilson ryanwilson Aug 9, 2018

Can you revert the project file and do those in a separate commit? They should be changed but no reason to be part of this PR :)

@ryanwilson ryanwilson requested a review from chliangGoogle Aug 9, 2018
@bstpierr bstpierr merged commit f95ee89 into master Aug 14, 2018
2 checks passed
@bstpierr bstpierr deleted the bs-messaging-category branch Aug 14, 2018
@wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Aug 14, 2018

Please remember to squash and merge unless you're merging a long-lived high-value branch (like a release branch).

@bstpierr
Copy link
Contributor Author

@bstpierr bstpierr commented Aug 14, 2018

Ah yes, sorry about that. I'll make sure to do so in the future.

@firebase firebase locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants