Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add message ID to direct channel message #1861

Merged
merged 2 commits into from Sep 24, 2018
Merged

add message ID to direct channel message #1861

merged 2 commits into from Sep 24, 2018

Conversation

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Sep 21, 2018

Also removed initWithMessage: method that is not used in source code and tests.

@paulb777 paulb777 dismissed morganchen12’s stale review Sep 24, 2018

Review comments have been addressed

@chliangGoogle chliangGoogle merged commit d8abc0d into master Sep 24, 2018
2 checks passed
@chliangGoogle chliangGoogle deleted the fcm-message branch Sep 24, 2018
@chliangGoogle chliangGoogle added this to the Firebase 6 milestone Sep 24, 2018
@paulb777 paulb777 removed this from the Firebase 6 milestone Feb 5, 2019
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants