Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add message ID to direct channel message #1861

Merged
merged 2 commits into from
Sep 24, 2018
Merged

add message ID to direct channel message #1861

merged 2 commits into from
Sep 24, 2018

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Sep 21, 2018

Also removed initWithMessage: method that is not used in source code and tests.

Firebase/Messaging/FIRMessaging.m Outdated Show resolved Hide resolved
@paulb777 paulb777 dismissed morganchen12’s stale review September 24, 2018 18:19

Review comments have been addressed

@charlotteliang charlotteliang merged commit d8abc0d into master Sep 24, 2018
@charlotteliang charlotteliang deleted the fcm-message branch September 24, 2018 20:05
@charlotteliang charlotteliang added this to the Firebase 6 milestone Sep 24, 2018
@paulb777 paulb777 removed this from the Firebase 6 milestone Feb 5, 2019
@firebase firebase locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants