Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Messaging and IID singleton usage during tests. #2250

Merged
merged 5 commits into from Jan 28, 2019

Conversation

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Jan 11, 2019

No description provided.

Copy link
Contributor

@chliangGoogle chliangGoogle left a comment

This means we can get rid of instanceIDForTest, right?

Copy link
Member

@paulb777 paulb777 left a comment

Not until making similar changes in RemoteConfig and Analytics

@paulb777
Copy link
Member

@paulb777 paulb777 commented Jan 11, 2019

cc: @htcgh


/// Starts fetching and configuration of InstanceID. This is necessary after the `initPrivately`
/// call.
- (void)start;
Copy link
Contributor

@chliangGoogle chliangGoogle Jan 11, 2019

I will see if can put start inside initPrivately so most team can just call initPrivately only.

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Jan 11, 2019

Yeah will do for both config and analytics

@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Jan 21, 2019

Update: I plan on getting back to this this week, removing the messagingForTests ended up being a larger change than expected.

@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Jan 23, 2019

Once Travis is green again this should be ready for re-review.

Copy link
Member

@paulb777 paulb777 left a comment

LGTM

@ryanwilson
Copy link
Member Author

@ryanwilson ryanwilson commented Jan 25, 2019

@chliangGoogle just wanted to confirm, are you good with these changes going in now?

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Jan 25, 2019

Yes! LGTM

@ryanwilson ryanwilson merged commit 5982981 into master Jan 28, 2019
2 checks passed
@ryanwilson ryanwilson deleted the rw-messaging-iid-tests branch Jan 28, 2019
@paulb777 paulb777 added this to the M43 milestone Feb 20, 2019
@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants