Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate setMinimumSessionInterval #2305

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@allenktv
Copy link
Contributor

commented Jan 23, 2019

Deprecate FIRAnalyticsConfiguration setMinimumSessionInterval due to sessions being started immediately.

This is being sent early for review, but will not be merged until the feature is rolled out.

@googlebot googlebot added the cla: yes label Jan 23, 2019

@allenktv allenktv changed the title Deprecate setMinimumSessionInterval DO NOT MERGE: Deprecate setMinimumSessionInterval Jan 23, 2019

@allenktv allenktv force-pushed the allenktv:master branch from 7f96dd2 to d1db262 Jan 31, 2019

@allenktv allenktv force-pushed the allenktv:master branch from d1db262 to 21344c5 Jan 31, 2019

@paulb777 paulb777 requested a review from ryanwilson Jan 31, 2019

@allenktv allenktv changed the title DO NOT MERGE: Deprecate setMinimumSessionInterval Deprecate setMinimumSessionInterval Feb 11, 2019

@allenktv

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

This can be merged now. The (internal) API review is at: go/scion-m43-api-review.

@ryanwilson ryanwilson added this to the M43 milestone Feb 13, 2019

@ryanwilson ryanwilson merged commit 83b5683 into firebase:master Feb 13, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

bstpierr added a commit that referenced this pull request Feb 19, 2019

Merge branch 'master' into bs-gullogger
* master:
  E2e tests split (#2401)
  Split auth api tests into multiple cases (#2399)
  Add a ToString function to create human-readable debug descriptions (#2384)
  Split Auth unit tests (#2396)
  Create umbrella header for FIAM (#2392)
  Deprecate setMinimumSessionInterval (#2305)
  Forbid queries endAt an uncommitted server timestamp. (#2382)
  update changelog for release (#2383)
  Fix FIAM Travic CI issues (#2380)
  Remove swift sample for Auth (#2371)
  C++ migration: port `FSTTransaction` (#2362)
  Fix a bug where unlinking emailpassword doesn’t remove provider data (#2370)
  Fix a bug where sign in with Game Center doesn’t return additional user info (#2368)
  Firebase In-app messaging callbacks (#2354)
  Fix a bug where sign in with email link always return isNewUser as false (#2363)
  C++ migration: eliminate `FSTRemoteStore` (#2338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.