Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate setMinimumSessionInterval #2305

Merged
merged 1 commit into from Feb 13, 2019
Merged

Deprecate setMinimumSessionInterval #2305

merged 1 commit into from Feb 13, 2019

Conversation

@allenktv
Copy link
Member

@allenktv allenktv commented Jan 23, 2019

Deprecate FIRAnalyticsConfiguration setMinimumSessionInterval due to sessions being started immediately.

This is being sent early for review, but will not be merged until the feature is rolled out.

@allenktv allenktv changed the title Deprecate setMinimumSessionInterval DO NOT MERGE: Deprecate setMinimumSessionInterval Jan 23, 2019
@paulb777 paulb777 requested a review from ryanwilson Jan 31, 2019
@allenktv allenktv changed the title DO NOT MERGE: Deprecate setMinimumSessionInterval Deprecate setMinimumSessionInterval Feb 11, 2019
@allenktv
Copy link
Member Author

@allenktv allenktv commented Feb 11, 2019

This can be merged now. The (internal) API review is at: go/scion-m43-api-review.

@ryanwilson ryanwilson added this to the M43 milestone Feb 13, 2019
@ryanwilson ryanwilson merged commit 83b5683 into firebase:master Feb 13, 2019
2 checks passed
bstpierr added a commit that referenced this issue Feb 19, 2019
* master:
  E2e tests split (#2401)
  Split auth api tests into multiple cases (#2399)
  Add a ToString function to create human-readable debug descriptions (#2384)
  Split Auth unit tests (#2396)
  Create umbrella header for FIAM (#2392)
  Deprecate setMinimumSessionInterval (#2305)
  Forbid queries endAt an uncommitted server timestamp. (#2382)
  update changelog for release (#2383)
  Fix FIAM Travic CI issues (#2380)
  Remove swift sample for Auth (#2371)
  C++ migration: port `FSTTransaction` (#2362)
  Fix a bug where unlinking emailpassword doesn’t remove provider data (#2370)
  Fix a bug where sign in with Game Center doesn’t return additional user info (#2368)
  Firebase In-app messaging callbacks (#2354)
  Fix a bug where sign in with email link always return isNewUser as false (#2363)
  C++ migration: eliminate `FSTRemoteStore` (#2338)
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants