Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic IDP support #2405

Merged
merged 8 commits into from Feb 23, 2019

Conversation

@Yue-Wang-Google
Copy link
Contributor

commented Feb 19, 2019

No description provided.

@googlebot googlebot added the cla: yes label Feb 19, 2019

@Yue-Wang-Google Yue-Wang-Google requested a review from renkelvin Feb 19, 2019

@Yue-Wang-Google Yue-Wang-Google force-pushed the headful-lite branch 8 times, most recently from e47433e to 307eaff Feb 20, 2019

@Yue-Wang-Google Yue-Wang-Google force-pushed the headful-lite branch from 307eaff to 55c8931 Feb 20, 2019

@Yue-Wang-Google Yue-Wang-Google requested a review from paulb777 Feb 22, 2019

@Yue-Wang-Google

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

Hi @paulb777 we're going to release this in M44. Do you know what might be causing the travis error below?

I didn't change the podspec at all.

 -> FirebaseAuth (5.3.0)
    - ERROR | [iOS] unknown: Encountered an unknown error (409: unexpected token at '{
        "availability" : "(available)",
        "state" : "Shutdown",
        "isAvailable" : true,
        "name" : "iPhone 5s",
') during validation.
[!] FirebaseAuth did not pass validation, due to 1 error.
You can use the `--no-clean` option to inspect any issue.
The command "./scripts/if_changed.sh ./scripts/pod_lib_lint.sh FirebaseAuth.podspec" failed. Retrying, 3 of 3.
Remove FIRUserMetadataTests.m from the project file which was previou…
…sly added by mistake. That file has nothing to do with the generic idp feature.
@paulb777

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

The paste you show above is a network flake, but there are real issues ...

Running locally in the branch shows the issues below. You should be able to debug in an Xcode workspace if you add the -no-clean option.

Let me know if you're still stuck after that.

pod lib lint FirebaseAuth.podspec

 -> FirebaseAuth (5.3.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file. (in target 'App')
    - ERROR | xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthProvider.m:26:9: fatal error: 'FIRAuthURLPresenter.h' file not found
    - WARN  | xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/FIRAuth.m:256:17: warning: method definition for 'signInWithProvider:UIDelegate:completion:' not found [-Wincomplete-implementation]
    - NOTE  | xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/Public/FIRAuth.h:513:1: note: method 'signInWithProvider:UIDelegate:completion:' declared here
    - WARN  | [tvOS] xcodebuild:  /Users/paulbeusterien/github/firebase-ios-sdk/Firebase/Auth/Source/FIRAuthWebUtils.m:168:24: warning: 'stringByReplacingPercentEscapesUsingEncoding:' is deprecated: first deprecated in tvOS 9.0 - Use -stringByRemovingPercentEncoding instead, which always uses the recommended UTF-8 encoding. [-Wdeprecated-declarations]
    - NOTE  | [tvOS] xcodebuild:  /Users/paulbeusterien/Downloads/Xcode-beta.app/Contents/Developer/Platforms/AppleTVSimulator.platform/Developer/SDKs/AppleTVSimulator12.2.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURL.h:593:1: note: 'stringByReplacingPercentEscapesUsingEncoding:' has been explicitly marked deprecated here

[!] FirebaseAuth did not pass validation, due to 1 error and 2 warnings.
You can use the `--no-clean` option to inspect any issue.
@renkelvin
Copy link
Collaborator

left a comment

Code already reviewed in the private repo. Ready to merge once the build issue is fixed.

Fix import for FIROAuthProvider.m. Only include "FIRAuthURLPresenter.…
…h" on iOS platform as it is excluded on other platforms.

@Yue-Wang-Google Yue-Wang-Google force-pushed the headful-lite branch from 5a393b5 to e6525d7 Feb 23, 2019

@paulb777
Copy link
Member

left a comment

LGTM, the fix for the travis failure is from a regression today for which the fix was just pushed to master.

@Yue-Wang-Google

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

All tests passed! Submitting.

@Yue-Wang-Google Yue-Wang-Google merged commit 2e77efd into master Feb 23, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paulb777 paulb777 added this to the M44 milestone Feb 23, 2019

@paulb777 paulb777 added the api: auth label Feb 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.