Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Microsoft and Yahoo Auth Provider ID #2517

Merged
merged 4 commits into from Mar 12, 2019

Conversation

@Yue-Wang-Google
Copy link
Contributor

@Yue-Wang-Google Yue-Wang-Google commented Mar 11, 2019

No description provided.

Copy link
Member

@ryanwilson ryanwilson left a comment

Small change then LGTM.

Firebase/Auth/Source/Public/FIROAuthProvider.h Outdated Show resolved Hide resolved
@Yue-Wang-Google Yue-Wang-Google requested a review from ryanwilson Mar 11, 2019
@renkelvin renkelvin added this to the M45 milestone Mar 12, 2019
Copy link
Member

@ryanwilson ryanwilson left a comment

Please fix the Travis whitespace issue, then LGTM. Thanks

@Yue-Wang-Google Yue-Wang-Google merged commit b67bc10 into master Mar 12, 2019
2 checks passed
@Yue-Wang-Google Yue-Wang-Google deleted the Yue-Wang-Google-patch-3 branch Mar 12, 2019
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants