Firebase Authentication's error code seems to be broken after upgrading to 5.4.0 #2522

mono0926 · 2019-03-12T07:20:07Z

Describe your environment

Xcode version: Version 10.1 (10B61, latest)
Firebase SDK version: 5.18.0 (latest)
Firebase Component: Auth (5.4.0, latest)

Describe the problem

My app's auth logic was broken after upgrading to Firebase Authentication 5.4.0, so I investigated that.
It seems that FIRAuthErrorCodeInternalError(17999) error started occurring for many requests.

Steps to reproduce:

This is one of the steps to reproduce the issue.

Login with anonymous Firebase user: success.
Tried to link the Firebase user to exiting linked Facebook account.

After that, FIRAuthErrorCodeCredentialAlreadyInUse(17025) should return, but after upgrading to Firebase Authentication 5.4.0, FIRAuthErrorCodeInternalError(17999)started returning.

import FirebaseAuth
import FBSDKLoginKit

let firUser = Auth.auth().currentUser!
FBSDKLoginManager().logIn(withReadPermissions: ["public_profile"], from: viewController) { (result, error) in
    let fbToken = result!.token!

    let credential = FacebookAuthProvider.credential(withAccessToken: fbToken.tokenString)

    firUser.linkAndRetrieveData(with: credential, completion: { (result, error) in
        // error code should be `FIRAuthErrorCodeCredentialAlreadyInUse(17025)`
        // error code is `FIRAuthErrorCodeInternalError(17999)` after upgrading to Firebase Authentication 5.4.0
    })
}

I suspect that #2405 is related? 🤔

The text was updated successfully, but these errors were encountered:

ryanwilson · 2019-03-12T11:25:03Z

@mono0926 thanks for the reply, @renkelvin or @Yue-Wang-Google can you please take a look?

renkelvin · 2019-03-12T19:37:38Z

@mono0926 Thanks for reporting! It's verified that the issue was introduced in #2405 and we're working on the fix. Thanks!

Fix #2522

Yue-Wang-Google · 2019-03-12T21:42:01Z

@mono0926 could you please try #2530 and see if it works for you? It works for me.

Fix #2522

Yue-Wang-Google · 2019-03-13T01:30:34Z

@mono0926 I'll close this bug for now as it works for me plus we're freezing the code tonight.
Feel free to comment below whether it resolves your problem or not.

mono0926 · 2019-03-13T05:57:32Z

@Yue-Wang-Google

Thanks, I checked that, but the issue seems to be not fixed unfortunately, so I'd like you to reopen this issue.

I checked it by running the code which pasted here( #2522 (comment) ), and add breakpoints to the code you modified.

v5.4.0 + #2530

shortErrorMessage is MISSING_ID_TOKEN.

v5.3.1

shortErrorMessage should be FEDERATED_USER_ID_ALREADY_LINKED.

You tried to fix kFederatedUserIDAlreadyLinkedMessage specific problem at #2530, but It might be more global problem as I said 🤔

My app's auth logic was broken after upgrading to Firebase Authentication 5.4.0, so I investigated that.
It seems that FIRAuthErrorCodeInternalError(17999) error started occurring for many requests.

Yue-Wang-Google · 2019-03-13T06:48:27Z

Thanks for reporting. #2530 did fix the issue when the user is new. However for existing users it seems the new code did return an wrong error. I'm going to reopen the issue. For now you could comment out FIRVerifyAssertionRequest.m's L154 (which set body[kReturnIDPCredentialKey] to @YES) or simply revert to the old version, if you need an urgent fix. I'll fix the bug tomorrow.

mono0926 · 2019-03-13T06:57:50Z

@Yue-Wang-Google

comment out FIRVerifyAssertionRequest.m's L154 (which set body[kReturnIDPCredentialKey] to @yES)

This fixed the problem, thanks!!

Another fix for #2522

mono0926 · 2019-03-13T08:00:17Z

@Yue-Wang-Google

I believe I found the official fix: #2541

Oh, it should be fixed.

But, unfortunately without FIRVerifyAssertionRequest.m's L154 change, the problem isn't fixed.

1 revert the comment in FIRVerifyAssertionRequest.m's L154 (set it back to YES) if you commented it out. kReturnIDPCredentialKey needs to be true in order to make OAuth working.

2 You need to apply #2541

3 You also need to apply the previous fix #2530 --- both changes are necessary.

Result:

In summary, the results is below:

Don't create credential when VerifyAssertionResponse is empty #2530 + Use oauthAccessToken instead of IDToken when returnIDPCredential is yes #2541: doesn't work
Don't create credential when VerifyAssertionResponse is empty #2530 + Use oauthAccessToken instead of IDToken when returnIDPCredential is yes #2541 + FIRVerifyAssertionRequest.m's L154 fix: works well
- without Use oauthAccessToken instead of IDToken when returnIDPCredential is yes #2541, it also works fine as commented here:
  Firebase Authentication's error code seems to be broken after upgrading to 5.4.0 #2522 (comment)

mono0926 · 2019-03-13T08:09:46Z

I believe I found the official fix: #2541

Oh, it should be fixed.

I suspect that it was correct because initial implementation(May 16, 2017) used response.IDToken 🤔

firebase-ios-sdk/Firebase/Auth/Source/FIRUser.m

Line 884 in 98ba644

accessToken:response.IDToken

…ntial=YES Fix #2522. In this case, the server returns an 200 without an error like the following: ``` [response data:] { "error": { "code": 400, "message": "FEDERATED_USER_ID_ALREADY_LINKED", "errors": [ { "message": "FEDERATED_USER_ID_ALREADY_LINKED", "domain": "global", "reason": "invalid" } ] } } ``` Rather, it is directly enclosed in the response with an errorMessage without a structure: ``` [response data:] { key: value ... "errorMessage": "FEDERATED_USER_ID_ALREADY_LINKED", "kind": "identitytoolkit#VerifyAssertionResponse" } ```

Yue-Wang-Google · 2019-03-13T09:17:56Z

I'm very sorry. @mono0926 I must be drunk. Please try #2542 with #2530. (you need both patches, and you need to revert the kReturnIDPCredentialKey comment)
I'm very confident that this is the right fix.

Again, thank you for testing and reporting the bug to us! Really appreciated (next time I am in Tokyo I'll invite you for a beer)!

mono0926 · 2019-03-13T10:05:00Z

Please try #2542 with #2530. (you need both patches, and you need to revert the kReturnIDPCredentialKey comment)

It works fine! Thanks for the quick fix 🙏

Yue-Wang-Google · 2019-03-13T10:10:56Z

It works fine! Thanks for the quick fix 🙏

Great! I'll wait for it to be approved by my colleague tomorrow, and after that v5.4.1 will be released.

Thanks for your bug report and testing my fixes. I will also keep my promise to buy you a beer, by the way:)

…2542) * extract errorMessage directly from response in case of returnIDPCredential=YES Fix #2522. In this case, the server returns an 200 without an error like the following: ``` [response data:] { "error": { "code": 400, "message": "FEDERATED_USER_ID_ALREADY_LINKED", "errors": [ { "message": "FEDERATED_USER_ID_ALREADY_LINKED", "domain": "global", "reason": "invalid" } ] } } ``` Rather, it is directly enclosed in the response with an errorMessage without a structure: ``` [response data:] { key: value ... "errorMessage": "FEDERATED_USER_ID_ALREADY_LINKED", "kind": "identitytoolkit#VerifyAssertionResponse" } ``` * Update Changelog

sentex · 2019-03-19T20:10:06Z

I have the same problem. Get FIRAuthErrorCodeInternalError(17999) after upgrading to Firebase Authentication 5.4.0

Yue-Wang-Google · 2019-03-19T20:32:00Z

@sentex it's fixed in 5.4.1. See https://github.com/firebase/firebase-ios-sdk/releases/tag/Auth-5.4.1

sentex · 2019-03-19T21:35:50Z

how can I install this version ?

Yue-Wang-Google · 2019-03-19T21:38:34Z

@sentex you can wait a day or two and see if it is upgraded on Cocoapods. Or, you can simply patch in #2542 and #2530.

paulb777 · 2019-03-19T21:39:56Z

Or see instructions at https://github.com/firebase/firebase-ios-sdk#accessing-firebase-source-snapshots or wait an hour or so. We're publishing to CocoaPods now.

google-oss-bot added the api: auth label Mar 12, 2019

mono0926 changed the title ~~Firebase Authenticator seems to be broken after upgrading 5.4.0~~ Firebase Authentication seems to be broken after upgrading 5.4.0 Mar 12, 2019

mono0926 changed the title ~~Firebase Authentication seems to be broken after upgrading 5.4.0~~ Firebase Authentication' error code seems to be broken after upgrading 5.4.0 Mar 12, 2019

mono0926 changed the title ~~Firebase Authentication' error code seems to be broken after upgrading 5.4.0~~ Firebase Authentication's error code seems to be broken after upgrading 5.4.0 Mar 12, 2019

mono0926 changed the title ~~Firebase Authentication's error code seems to be broken after upgrading 5.4.0~~ Firebase Authentication's error code seems to be broken after upgrading to 5.4.0 Mar 12, 2019

ryanwilson assigned renkelvin and Yue-Wang-Google Mar 12, 2019

paulb777 added this to the M45 milestone Mar 12, 2019

Yue-Wang-Google added a commit that referenced this issue Mar 12, 2019

Don't create credential when VerifyAssertionResponse is empty

1540a77

Fix #2522

Yue-Wang-Google mentioned this issue Mar 12, 2019

Don't create credential when VerifyAssertionResponse is empty #2530

Merged

Yue-Wang-Google closed this as completed in #2530 Mar 13, 2019

Yue-Wang-Google added a commit that referenced this issue Mar 13, 2019

Don't create credential when VerifyAssertionResponse is empty (#2530)

b1f909e

Fix #2522

Yue-Wang-Google reopened this Mar 13, 2019

Yue-Wang-Google added a commit that referenced this issue Mar 13, 2019

Use oauthAccessToken instead of IDToken when returnIDPCredential is yes

7d1edd2

Another fix for #2522

Yue-Wang-Google mentioned this issue Mar 13, 2019

Use oauthAccessToken instead of IDToken when returnIDPCredential is yes #2541

Closed

Yue-Wang-Google mentioned this issue Mar 13, 2019

extract errorMessage directly from response when server returns 200 #2542

Merged

paulb777 closed this as completed in #2542 Mar 13, 2019

renkelvin mentioned this issue Apr 9, 2019

Update CHANGELOG.md #2781

Merged

firebase locked and limited conversation to collaborators Oct 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firebase Authentication's error code seems to be broken after upgrading to 5.4.0 #2522

Firebase Authentication's error code seems to be broken after upgrading to 5.4.0 #2522

mono0926 commented Mar 12, 2019 •

edited

ryanwilson commented Mar 12, 2019

renkelvin commented Mar 12, 2019

Yue-Wang-Google commented Mar 12, 2019

Yue-Wang-Google commented Mar 13, 2019

mono0926 commented Mar 13, 2019

Yue-Wang-Google commented Mar 13, 2019 •

edited

mono0926 commented Mar 13, 2019 •

edited

mono0926 commented Mar 13, 2019 •

edited

mono0926 commented Mar 13, 2019

Yue-Wang-Google commented Mar 13, 2019 •

edited

mono0926 commented Mar 13, 2019

Yue-Wang-Google commented Mar 13, 2019

sentex commented Mar 19, 2019

Yue-Wang-Google commented Mar 19, 2019 •

edited

sentex commented Mar 19, 2019

Yue-Wang-Google commented Mar 19, 2019

paulb777 commented Mar 19, 2019

Firebase Authentication's error code seems to be broken after upgrading to 5.4.0 #2522

Firebase Authentication's error code seems to be broken after upgrading to 5.4.0 #2522

Comments

mono0926 commented Mar 12, 2019 • edited

Describe your environment

Describe the problem

Steps to reproduce:

ryanwilson commented Mar 12, 2019

renkelvin commented Mar 12, 2019

Yue-Wang-Google commented Mar 12, 2019

Yue-Wang-Google commented Mar 13, 2019

mono0926 commented Mar 13, 2019

v5.4.0 + #2530

v5.3.1

Yue-Wang-Google commented Mar 13, 2019 • edited

mono0926 commented Mar 13, 2019 • edited

mono0926 commented Mar 13, 2019 • edited

mono0926 commented Mar 13, 2019

Yue-Wang-Google commented Mar 13, 2019 • edited

mono0926 commented Mar 13, 2019

Yue-Wang-Google commented Mar 13, 2019

sentex commented Mar 19, 2019

Yue-Wang-Google commented Mar 19, 2019 • edited

sentex commented Mar 19, 2019

Yue-Wang-Google commented Mar 19, 2019

paulb777 commented Mar 19, 2019

mono0926 commented Mar 12, 2019 •

edited

Yue-Wang-Google commented Mar 13, 2019 •

edited

mono0926 commented Mar 13, 2019 •

edited

mono0926 commented Mar 13, 2019 •

edited

Yue-Wang-Google commented Mar 13, 2019 •

edited

Yue-Wang-Google commented Mar 19, 2019 •

edited