Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue where matchesshortlinkformat was returning true for all links. #2563

Merged
merged 2 commits into from Mar 19, 2019

Conversation

@dmandar
Copy link
Contributor

@dmandar dmandar commented Mar 15, 2019

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.
@dmandar dmandar changed the title Md matchesshortlinkformat bugfix Fix for issue where matchesshortlinkformat was returning true for all links. Mar 15, 2019
@dmandar dmandar requested review from paulb777 and mh6o Mar 15, 2019
Copy link
Member

@paulb777 paulb777 left a comment

LGTM

Does this fix one of the open issues? If so, which one?

@dmandar
Copy link
Contributor Author

@dmandar dmandar commented Mar 15, 2019

Fixes internal bug 111250742.

@dmandar dmandar merged commit 3c3fe79 into master Mar 19, 2019
2 checks passed
@dmandar dmandar deleted the md-matchesshortlinkformat-bugfix branch Mar 19, 2019
Corrob added a commit that referenced this issue Apr 25, 2019
… links. (#2563)

* Fix issue with matchesShortLinkFormat always returning true.

* Fix style.
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants