Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API to connect direct channel #2717

Merged
merged 3 commits into from Apr 5, 2019

Conversation

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Apr 3, 2019

Should use shouldEstablishDirectChannel property instead.

Copy link
Member

@ryanwilson ryanwilson left a comment

One nit then LGTM.

Firebase/Messaging/FIRMMessageCode.h Outdated Show resolved Hide resolved
@chliangGoogle chliangGoogle requested a review from ryanwilson Apr 4, 2019
@paulb777
Copy link
Member

@paulb777 paulb777 commented Apr 4, 2019

Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

LGTM

@chliangGoogle
Copy link
Contributor Author

@chliangGoogle chliangGoogle commented Apr 5, 2019

@ryanwilson I think the PR needs your approval to be merged.

@paulb777 paulb777 dismissed ryanwilson’s stale review Apr 5, 2019

Ryan's nit was addressed

@chliangGoogle chliangGoogle merged commit f025da1 into master Apr 5, 2019
2 checks passed
@chliangGoogle chliangGoogle deleted the fcm-deprecate-connect branch Apr 5, 2019
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants