Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support card template display in FIAM iOS SDK #2947

Merged
merged 67 commits into from May 24, 2019
Merged

Support card template display in FIAM iOS SDK #2947

merged 67 commits into from May 24, 2019

Conversation

@christibbs
Copy link
Contributor

@christibbs christibbs commented May 6, 2019

Adds parsing logic and UI for a new In-App Messaging template with a card-style look.

Also makes some changes to the FIRInAppMessagingDisplayDelegate protocol:

  • Deprecates messageClicked: in favor of messageClicked:withAction:, which is necessary since the card template can have two actions and the developer may need to know which was fired.
  • Makes all methods optional for less boilerplate app-side code when implementing the protocol.

To reviewers: sorry, wasn't sure how to avoid this being one massive PR.

card_screenshot

christibbs added 30 commits Feb 11, 2019
Copy link
Member

@paulb777 paulb777 left a comment

Do not add the file default.profraw

@paulb777
Copy link
Member

@paulb777 paulb777 commented May 14, 2019

Thanks! Deferring to @ryanwilson for PR approval.

Copy link
Member

@ryanwilson ryanwilson left a comment

Still reviewing, leaving comments for now to address as I go.

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented May 24, 2019

LGTM once travis is green! Thanks for working with us on this :)

@christibbs christibbs merged commit 4a33b26 into master May 24, 2019
2 checks passed
@paulb777 paulb777 deleted the fiam-card-display branch Oct 2, 2019
@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants