Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIAM Programmatic triggers #3081

Merged
merged 79 commits into from May 28, 2019

Conversation

@christibbs
Copy link
Collaborator

commented May 24, 2019

Adds public method triggerEvent: on FIRInAppMessaging to directly call on FIRIAMDisplayExecutor to check the message queue and display a contextual triggered message if applicable.

Also adds unit tests and some UI functionality on the test app to trigger this flow during manual testing.

3ca83a6 also fixes an issue where overriding the access levels of readonly properties in FIRInAppMessagingCardDisplay in a private header wasn't working as expected.

christibbs added 30 commits Feb 11, 2019
christibbs added 16 commits May 14, 2019
Mark some properties on the card object as readonly that should've be…
…en already, Find a way to initialize a card message in the UI tests.

@christibbs christibbs requested a review from prakhar1989 May 24, 2019

@googlebot googlebot added the cla: yes label May 24, 2019

@MeghaB
Copy link

left a comment

adding myself

@MeghaB
Copy link

left a comment

API Looks good, made some logging/naming comments, and had some questions which (potentially) could just be iOS patterns, but curious :)

christibbs added 2 commits May 28, 2019
Reuse analytic trigger method to show programmatic messages. Fix issu…
…e with overriding accessibility of card message params
@morganchen12
Copy link
Collaborator

left a comment

LGTM with one curiosity

@christibbs christibbs merged commit 93ebe6f into master May 28, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@christibbs christibbs deleted the fiam-programmatic-triggers branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.