Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Raise exception when log into Facebook using OAuth. (#3138)" #3208

Merged
merged 1 commit into from Jun 18, 2019

Conversation

@renkelvin
Copy link
Collaborator

commented Jun 18, 2019

This is likely a breaking change and an error should be logged instead.

@googlebot googlebot added the cla: yes label Jun 18, 2019

@renkelvin renkelvin requested a review from ryanwilson Jun 18, 2019

@renkelvin renkelvin merged commit 227f856 into master Jun 18, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
cla/google All necessary CLAs are signed

@renkelvin renkelvin deleted the revert-oauth-facebook branch Jun 18, 2019

ryanwilson added a commit that referenced this pull request Jun 18, 2019
ryanwilson added a commit that referenced this pull request Jun 18, 2019
ryanwilson added a commit that referenced this pull request Jun 19, 2019
Merging the 6.3.0 release into master (#3217)
* Update versions for Release 6.3.0

* Revert "Raise exception when log into Facebook using OAuth.  (#3138)" (#3208) (#3209)

This reverts commit 393d060.

@paulb777 paulb777 added this to the 6.7.0 milestone Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.