Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependency on AppKit to fix Firestore build #3459

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@wilhuff
Copy link
Member

commented Jul 29, 2019

This fixes the Firestore CMake build (see breakage in https://travis-ci.org/firebase/firebase-ios-sdk/jobs/565061251).

@@ -28,6 +28,7 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
s.public_header_files = 'Firebase/Core/Public/*.h', 'Firebase/Core/Private/*.h'
s.private_header_files = 'Firebase/Core/Private/*.h'
s.framework = 'Foundation'
s.osx.framework = 'AppKit'

This comment has been minimized.

Copy link
@paulb777

paulb777 Jul 29, 2019

Member

Thanks!

It also needs

s.ios.framework = 'UIKit'
s.tvos.framework = 'UIKit'

This comment has been minimized.

Copy link
@wilhuff

wilhuff Jul 29, 2019

Author Member

Done (in alphabetical order, matching the order of deployment_target above).

@wilhuff wilhuff merged commit ac34398 into master Jul 29, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilhuff wilhuff deleted the wilhuff/appkit branch Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.