Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependency on AppKit to fix Firestore build #3459

Merged
merged 2 commits into from Jul 29, 2019
Merged

Conversation

wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jul 29, 2019

This fixes the Firestore CMake build (see breakage in https://travis-ci.org/firebase/firebase-ios-sdk/jobs/565061251).

@@ -28,6 +28,7 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
s.public_header_files = 'Firebase/Core/Public/*.h', 'Firebase/Core/Private/*.h'
s.private_header_files = 'Firebase/Core/Private/*.h'
s.framework = 'Foundation'
s.osx.framework = 'AppKit'
Copy link
Member

@paulb777 paulb777 Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It also needs

s.ios.framework = 'UIKit'
s.tvos.framework = 'UIKit'

Copy link
Contributor Author

@wilhuff wilhuff Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (in alphabetical order, matching the order of deployment_target above).

@wilhuff wilhuff merged commit ac34398 into master Jul 29, 2019
2 checks passed
@wilhuff wilhuff deleted the wilhuff/appkit branch Jul 29, 2019
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants