Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename a few methods and properties to fit in the readability #3498

Merged
merged 4 commits into from Aug 5, 2019

Conversation

@chliangGoogle
Copy link
Collaborator

commented Aug 2, 2019

We have a few methods in FIRMessagingRemoteNotificationsProxy.m doesn't follow objective C naming convention, also they can be confused with the run time methods with "_" in the naming.
b/65217183

Tested: Analytics logging is working after swizzling.

@googlebot googlebot added the cla: yes label Aug 2, 2019

@morganchen12
Copy link
Collaborator

left a comment

LGTM with one more nit.

@chliangGoogle chliangGoogle merged commit 80faf74 into master Aug 5, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chliangGoogle chliangGoogle deleted the fcm-assert branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.