Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename a few methods and properties to fit in the readability #3498

merged 4 commits into from Aug 5, 2019


Copy link

@chliangGoogle chliangGoogle commented Aug 2, 2019

We have a few methods in FIRMessagingRemoteNotificationsProxy.m doesn't follow objective C naming convention, also they can be confused with the run time methods with "_" in the naming.

Tested: Analytics logging is working after swizzling.

Copy link

@morganchen12 morganchen12 left a comment

LGTM with one more nit.

Firebase/Messaging/FIRMessagingRemoteNotificationsProxy.m Outdated Show resolved Hide resolved
@chliangGoogle chliangGoogle merged commit 80faf74 into master Aug 5, 2019
2 checks passed
@chliangGoogle chliangGoogle deleted the fcm-assert branch Aug 5, 2019
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants