Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Auth from UIWebView to WKWebView #3549

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@paulb777
Copy link
Member

commented Aug 11, 2019

WKWebView was introduced in iOS 8 and is the only WebView option for Catalyst.

Builds and passes unit tests for Catalyst.

@paulb777

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

@renkelvin It doesn't look like the unit or integration tests include tests for the WebView. Would you either do the testing or add tests?

@renkelvin

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

@paulb777 WebView is only used on iOS 8 and we don't have testing for that. I can't do some tests on the latest platforms.

@paulb777 paulb777 merged commit f841497 into master Aug 12, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@paulb777 paulb777 deleted the pb-catalyst-auth branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.