Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill debug assert and unnecessary macros #3556

Merged
merged 6 commits into from Aug 13, 2019

Conversation

@chliangGoogle
Copy link
Collaborator

commented Aug 12, 2019

Remove _FIRMessagingDevAssert that are only called if a DEBUG flag, which is never set in both debug/production build. Most of the assert logics are already been checked in the code, for the ones that are not, we replace it with a debugLog.
Also remove a few macros that are either not used at all or barely used.

@googlebot googlebot added the cla: yes label Aug 12, 2019

@chliangGoogle chliangGoogle changed the title kill debug code kill debug assert and unnecessary macros Aug 12, 2019

@morganchen12
Copy link
Collaborator

left a comment

Consider replacing all or some of these asserts with warning logs.

@morganchen12
Copy link
Collaborator

left a comment

LGTM, but please wait for core approval before merging.

@chliangGoogle

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2019

Good catch! I'm adding more debug/warning logs.

@paulb777

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Looks like real failures in travis:

Failing tests:
	-[FIRMessagingServiceTest testSubscribeWithInvalidTopic]
	-[FIRMessagingServiceTest testSubscribeWithInvalidTopic]
	-[FIRMessagingServiceTest testSubscribeWithInvalidTopic]
	-[FIRMessagingServiceTest testUnsubscribeWithInvalidTopic]
	-[FIRMessagingServiceTest testUnsubscribeWithInvalidTopic]
	-[FIRMessagingServiceTest testUnsubscribeWithInvalidTopic]

@chliangGoogle chliangGoogle merged commit eade6bd into master Aug 13, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chliangGoogle chliangGoogle deleted the fcm-kill-devAssert branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.