Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move two internal iid headers to private for RC open sourcing #3621

Merged
merged 2 commits into from Aug 19, 2019

Conversation

@paulb777
Copy link
Member

commented Aug 18, 2019

Migrate the two required InstanceID headers for RemoteConfig from internal to private.

After RC is added to the repo, consider consolidating ./Firebase/InstanceID/Private/FIRInstanceID+Private.h and
./Firebase/InstanceID/Private/FIRInstanceID_Private.h

@googlebot googlebot added the cla: yes label Aug 18, 2019
Copy link
Contributor

left a comment

LGTM

@paulb777 paulb777 merged commit 2741ec3 into master Aug 19, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@paulb777 paulb777 deleted the pb-iid-private2 branch Aug 19, 2019
@chliangGoogle chliangGoogle added this to the M55 milestone Aug 27, 2019
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.