Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FIAM for iOS 13 Scene lifecycle paradigm #3927

Merged
merged 6 commits into from Oct 2, 2019

Conversation

@christibbs
Copy link
Collaborator

commented Sep 25, 2019

Two key fixes:

  • Throw both UIScene and UIApplication lifecycle notifications
  • Update UIWindow creation logic to initialize based on a foregrounded scene (if iOS 13 is available)

Fixes #3524 with the exception around concerns with opening URL from a scene. From testing, though, current URL opening logic still works as intended.

@christibbs christibbs requested review from paulb777 and ryanwilson Sep 25, 2019
@googlebot googlebot added the cla: yes label Sep 25, 2019
@christibbs christibbs requested review from mikehaney24 and maksymmalyhin Sep 25, 2019

#if defined(__IPHONE_13_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 130000
if (@available(iOS 13.0, *)) {
[[NSNotificationCenter defaultCenter] addObserver:self

This comment has been minimized.

Copy link
@ryanwilson

ryanwilson Sep 26, 2019

Member

Are there situations where appWillBecomeInactive could be called twice, i.e. could UIApplicationWillResignActiveNotification and UISceneWillDeactivateNotification both be fired for the same app close?

This comment has been minimized.

Copy link
@mikehaney24

mikehaney24 Sep 27, 2019

Collaborator

Same thing for becoming active.


#if defined(__IPHONE_13_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 130000
if (@available(iOS 13.0, *)) {
[[NSNotificationCenter defaultCenter] addObserver:self

This comment has been minimized.

Copy link
@mikehaney24

mikehaney24 Sep 27, 2019

Collaborator

Same thing for becoming active.

@christibbs christibbs removed request for paulb777 and maksymmalyhin Oct 1, 2019
@ryanwilson ryanwilson merged commit eca2170 into master Oct 2, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ryanwilson ryanwilson deleted the fiam-ios-13-scene branch Oct 2, 2019
schmidt-sebastian added a commit that referenced this pull request Oct 2, 2019
* Add UIScene lifecycle notifications alongside UIApplication ones

* Run styles.sh and update window helper to work on iOS 13

* Refactor foregrounded scene logic into its own method

* Conditional compilation for iOS 13 code

* Add notification parameter to notification selectors

* Fix placeholder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.