Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migration logic from document folder to application folder #4033

Merged
merged 6 commits into from Oct 10, 2019

Conversation

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Oct 9, 2019

We used to store files in document folder (more than 2 years ago) and had migration logic that if document folder exist, move the content to application folder.

Remove the migration logic since the majority of the users already store data in the application folder. The data we wrote in the disks are plist file and cached non-ack mcs channel message IDs, which are not critical information even if a very old user still kept the document folder (who hasn't opened his app for more than 2 years).

Also remove production code that is only used for testing, should expose the method through category instead.

@chliangGoogle chliangGoogle requested a review from morganchen12 Oct 9, 2019
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

LGTM

@chliangGoogle chliangGoogle merged commit b6ac437 into master Oct 10, 2019
2 checks passed
@chliangGoogle chliangGoogle deleted the oct-fcm-directory branch Oct 10, 2019
@firebase firebase locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants