Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UIApplication.connectedScenes on iOS 13 #4066

Merged
merged 2 commits into from Oct 15, 2019
Merged

Use UIApplication.connectedScenes on iOS 13 #4066

merged 2 commits into from Oct 15, 2019

Conversation

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Oct 14, 2019

Solve item #3 for #3521

Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

LGTM

} else {
UIApplication *application = [applicationClass sharedApplication];
topViewController = application.keyWindow.rootViewController;
}
Copy link
Contributor

@maksymmalyhin maksymmalyhin Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: moving this code out to a separate method may improve readability of the code.

Copy link
Contributor Author

@renkelvin renkelvin Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried while it seems the code blocks depend on each other and hard to be separated.

Copy link
Contributor

@maksymmalyhin maksymmalyhin Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, no problem

@renkelvin renkelvin merged commit 5a39cf1 into master Oct 15, 2019
1 check passed
@renkelvin renkelvin deleted the keyWindow branch Oct 15, 2019
@paulb777 paulb777 added this to the 6.11.0 milestone Oct 16, 2019
@firebase firebase locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants