Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC nonce support #4183

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@renkelvin
Copy link
Contributor

renkelvin commented Oct 29, 2019

No description provided.

@renkelvin renkelvin requested a review from paulb777 Oct 29, 2019
@googlebot googlebot added the cla: yes label Oct 29, 2019
@renkelvin

This comment has been minimized.

Copy link
Contributor Author

renkelvin commented Oct 29, 2019

Resubmit #4071

@renkelvin renkelvin requested a review from ryanwilson Oct 29, 2019
@renkelvin renkelvin merged commit ffe4a3a into master Oct 29, 2019
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Congrats.
@renkelvin renkelvin deleted the oidc-nonce branch Oct 29, 2019
renkelvin added a commit that referenced this pull request Nov 1, 2019
This reverts commit ffe4a3a.
renkelvin added a commit that referenced this pull request Nov 1, 2019
This reverts commit ffe4a3a.
maksymmalyhin added a commit that referenced this pull request Nov 1, 2019
This reverts commit ffe4a3a.
maksymmalyhin added a commit that referenced this pull request Nov 1, 2019
This reverts commit ffe4a3a.
maksymmalyhin added a commit that referenced this pull request Nov 6, 2019
* Update versions for Release 6.12.0

* Update versions for Release 6.12.0 - Firestore

* Update versions for Release 6.12.0

* Update CHANGELOG for Firestore v1.7.0 (#4195)

* FirebaseCore version bump to 6.3.3 (#4213)

* Release manifst updated. (#4219)

* Revert "Add OIDC nonce support (#4183)" (#4220) (#4222)

This reverts commit ffe4a3a.

* Revert Auth podspec version bump. (#4232)

* Release manifest - Auth removed (#4233)

* 6.12.0: Firebase.podspec FirebaseAuth pod version reverted, cherry-pick #4231 (#4234)

* Firebase.podspec - revert Auth

* check_whitespaces.sh: ignore notices. (#4231)

* Remove unnecessary NOTICES file (#4242)
renkelvin added a commit that referenced this pull request Nov 12, 2019
This reverts commit 11a3417.
renkelvin added a commit that referenced this pull request Nov 12, 2019
This reverts commit 11a3417.
@@ -108,6 +120,7 @@ - (nullable instancetype)initWithCoder:(NSCoder *)aDecoder {

- (void)encodeWithCoder:(NSCoder *)aCoder {
[aCoder encodeObject:self.IDToken forKey:@"IDToken"];
[aCoder encodeObject:self.IDToken forKey:@"rawNonce"];

This comment has been minimized.

Copy link
@mozeryansky

mozeryansky Nov 17, 2019

Shouldn't this be self.rawNonce instead of self.IDToken?

This comment has been minimized.

Copy link
@renkelvin

renkelvin Nov 18, 2019

Author Contributor

Thanks! Fixed here.

This comment has been minimized.

Copy link
@mozeryansky

mozeryansky Nov 19, 2019

Sorry, but where was it fixed? (I can't wait to use this!)

This comment has been minimized.

Copy link
@morganchen12

This comment has been minimized.

Copy link
@renkelvin

renkelvin Nov 19, 2019

Author Contributor

Hey Michael, may I know how serious this bug is in your case? It helps us better understanding our developers. Thanks!

This comment has been minimized.

Copy link
@mozeryansky

mozeryansky Nov 19, 2019

I haven't used this yet, I was looking through the code because I plan to use this feature in the future.

This comment has been minimized.

Copy link
@renkelvin

renkelvin Nov 19, 2019

Author Contributor

The fix will be in the next release. For now, the feature should be good enough to use.

@paulb777 paulb777 added this to the M60.1 milestone Nov 20, 2019
@paulb777 paulb777 modified the milestones: M60.1, M61 Nov 28, 2019
@firebase firebase locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.