Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC nonce support #4183

Merged
merged 1 commit into from Oct 29, 2019
Merged

Add OIDC nonce support #4183

merged 1 commit into from Oct 29, 2019

Conversation

renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Oct 29, 2019

No description provided.

@renkelvin renkelvin requested a review from paulb777 Oct 29, 2019
@renkelvin
Copy link
Contributor Author

@renkelvin renkelvin commented Oct 29, 2019

Resubmit #4071

@renkelvin renkelvin merged commit ffe4a3a into master Oct 29, 2019
3 checks passed
@renkelvin renkelvin deleted the oidc-nonce branch Oct 29, 2019
renkelvin added a commit that referenced this issue Nov 1, 2019
renkelvin added a commit that referenced this issue Nov 1, 2019
maksymmalyhin pushed a commit that referenced this issue Nov 1, 2019
maksymmalyhin added a commit that referenced this issue Nov 1, 2019
maksymmalyhin added a commit that referenced this issue Nov 6, 2019
* Update versions for Release 6.12.0

* Update versions for Release 6.12.0 - Firestore

* Update versions for Release 6.12.0

* Update CHANGELOG for Firestore v1.7.0 (#4195)

* FirebaseCore version bump to 6.3.3 (#4213)

* Release manifst updated. (#4219)

* Revert "Add OIDC nonce support (#4183)" (#4220) (#4222)

This reverts commit ffe4a3a.

* Revert Auth podspec version bump. (#4232)

* Release manifest - Auth removed (#4233)

* 6.12.0: Firebase.podspec FirebaseAuth pod version reverted, cherry-pick #4231 (#4234)

* Firebase.podspec - revert Auth

* check_whitespaces.sh: ignore notices. (#4231)

* Remove unnecessary NOTICES file (#4242)
renkelvin added a commit that referenced this issue Nov 12, 2019
renkelvin added a commit that referenced this issue Nov 12, 2019
@@ -108,6 +120,7 @@ - (nullable instancetype)initWithCoder:(NSCoder *)aDecoder {

- (void)encodeWithCoder:(NSCoder *)aCoder {
[aCoder encodeObject:self.IDToken forKey:@"IDToken"];
[aCoder encodeObject:self.IDToken forKey:@"rawNonce"];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be self.rawNonce instead of self.IDToken?

Copy link
Contributor Author

@renkelvin renkelvin Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but where was it fixed? (I can't wait to use this!)

Copy link
Contributor

@morganchen12 morganchen12 Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@renkelvin renkelvin Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Michael, may I know how serious this bug is in your case? It helps us better understanding our developers. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used this yet, I was looking through the code because I plan to use this feature in the future.

Copy link
Contributor Author

@renkelvin renkelvin Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix will be in the next release. For now, the feature should be good enough to use.

@paulb777 paulb777 added this to the M60.1 milestone Nov 20, 2019
@paulb777 paulb777 removed this from the M60.1 milestone Nov 28, 2019
@paulb777 paulb777 added this to the M61 milestone Nov 28, 2019
@firebase firebase locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants