Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not activate if fetch returns NO_CHANGE #4260

Merged
merged 4 commits into from Nov 8, 2019

Conversation

@dmandar
Copy link
Contributor

dmandar commented Nov 7, 2019

Fixes internal bug: 143622863. We activate only if fetched data has not resulted in a data change. We track this using the last time the ETag was changed (corresponds to a real change to the RC template).
This change also mirrors current android behavior.

@@ -76,6 +76,8 @@
@property(nonatomic, readwrite, assign) NSTimeInterval lastSetDefaultsTimeInterval;
/// The latest eTag value stored from the last successful response.
@property(nonatomic, readwrite, assign) NSString *lastETag;
/// The timestamp of the last eTag update.
@property(nonatomic, readwrite, assign) NSTimeInterval lastETagUpdateTime;

This comment has been minimized.

Copy link
@chliangGoogle

chliangGoogle Nov 7, 2019

Contributor

should we persist this value? cuz what happened before the current app launch.

This comment has been minimized.

Copy link
@dmandar

dmandar Nov 8, 2019

Author Contributor

good pt. Done.

DISPATCH_QUEUE_SERIAL);
_configFetch[i] = OCMPartialMock([[RCNConfigFetch alloc] initWithContent:configContent
DBManager:_DBManager
settings:settings

This comment has been minimized.

Copy link
@chliangGoogle

chliangGoogle Nov 7, 2019

Contributor

is this format right? Maybe run script/style.sh

This comment has been minimized.

Copy link
@dmandar

dmandar Nov 8, 2019

Author Contributor

This is with style.sh.

@dmandar dmandar merged commit 3b9fd3d into master Nov 8, 2019
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Well done.
kokoro Kokoro build finished
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.