Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRStorage.callbackQueue fixes #4281

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@maksymmalyhin
Copy link
Contributor

maksymmalyhin commented Nov 11, 2019

  • fixes from cl/278915086 applied
@maksymmalyhin maksymmalyhin merged commit a3197cc into master Nov 11, 2019
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Well done.
kokoro Kokoro build finished
Details
@maksymmalyhin maksymmalyhin deleted the mm/warning-fix branch Nov 11, 2019
@@ -236,6 +236,10 @@ - (FIRStorageReference *)referenceWithPath:(NSString *)string {
return reference;
}

- (dispatch_queue_t)callbackQueue {
return _fetcherServiceForApp.callbackQueue;

This comment has been minimized.

Copy link
@schmidt-sebastian

schmidt-sebastian Nov 11, 2019

Member

Hm. Sorry for already approving this, but doesn't this break the ability for the developer to specify an override for the callback queue?

This comment has been minimized.

Copy link
@schmidt-sebastian

schmidt-sebastian Nov 11, 2019

Member

Apparently the solution to this mystery lies in line 244 :) Please ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.